Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka Typed Logger missing log() method #24648

Closed
ktoso opened this issue Mar 2, 2018 · 3 comments
Closed

Akka Typed Logger missing log() method #24648

ktoso opened this issue Mar 2, 2018 · 3 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:typed
Milestone

Comments

@ktoso
Copy link
Member

ktoso commented Mar 2, 2018

The new Logger trait is excellent, it misses the log() method though :)

It is super useful when loglevel comes from config:

if (logLevel != Logging.OffLevel) context.log.log(logLevel, "Stashing message: {}", msg)
@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:typed labels Mar 2, 2018
@txsmith
Copy link
Contributor

txsmith commented Mar 3, 2018

Hi, I might want to pick this up. Do you think this is suitable as a first contribution?

@ktoso
Copy link
Member Author

ktoso commented Mar 3, 2018

Sure! Thanks a lot :) it should be fairly simple, if not sure about anything please ask

@ktoso
Copy link
Member Author

ktoso commented Mar 3, 2018

See the log method on the untyped LoggerAdapter for what the signature should be. It might need more overloads due to the Marker

txsmith added a commit to delftswa2018/akka that referenced this issue Mar 3, 2018
txsmith added a commit to delftswa2018/akka that referenced this issue Mar 3, 2018
@johanandren johanandren added this to the 2.5.12 milestone Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:typed
Projects
None yet
Development

No branches or pull requests

3 participants