Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take cluster unreachability info into account in routers #26355

Closed
patriknw opened this issue Feb 9, 2019 · 1 comment
Closed

Take cluster unreachability info into account in routers #26355

patriknw opened this issue Feb 9, 2019 · 1 comment
Assignees
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:cluster t:typed
Milestone

Comments

@patriknw
Copy link
Member

patriknw commented Feb 9, 2019

A nice addition to the routers in Typed would be to subscribe to unreachable events and avoid routing to those, as described in https://akka.io/blog/2017/09/28/typed-cluster

It would be cool if we don't have to have a special type of routers in cluster. Would it make sense to add the facility to subscribe to unreachability via the Receptionist, and then the ClusterReceptionist would hook into cluster events? Should it be part of the ordinary Listing subscription or a separate subscription?

The routers probably want to avoid sending to unreachable, but if there are no reachable it's probably best to try to send to an unreachable than not at all.

@patriknw patriknw added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:cluster t:typed labels Feb 9, 2019
@johanandren
Copy link
Member

Maybe it should always provide that information, so you subscribe, and then the Listing unapply provides only reachable, and you could get the reachable ones with a separate method on the listing message. This would mean that the cluster receptionist may need to send out more listing messages (every time reachability changes) but perhaps that is fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:cluster t:typed
Projects
None yet
Development

No branches or pull requests

2 participants