Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publishing with JDK17 fails due to sbt-osgi #31132

Closed
pvlugter opened this issue Feb 17, 2022 · 8 comments
Closed

Publishing with JDK17 fails due to sbt-osgi #31132

pvlugter opened this issue Feb 17, 2022 · 8 comments
Labels
t:build t:osgi

Comments

@pvlugter
Copy link
Contributor

pvlugter commented Feb 17, 2022 •
edited
Loading

The JDK 17 builds are failing with ConcurrentModificationExceptions for the osgiBundle task.

https://github.com/akka/akka/runs/5225034561?check_suite_focus=true

https://github.com/akka/akka/runs/5225034721?check_suite_focus=true

[error] java.util.ConcurrentModificationException
[error] 	at java.base/java.util.TreeMap.callMappingFunctionWithCheck(TreeMap.java:750)
[error] 	at java.base/java.util.TreeMap.computeIfAbsent(TreeMap.java:604)
[error] 	at aQute.bnd.osgi.Jar.putResource(Jar.java:259)
[error] 	at aQute.bnd.osgi.Jar$1.visitFile(Jar.java:186)
[error] 	at aQute.bnd.osgi.Jar$1.visitFile(Jar.java:167)
[error] 	at java.base/java.nio.file.Files.walkFileTree(Files.java:2811)
[error] 	at aQute.bnd.osgi.Jar.buildFromDirectory(Jar.java:166)
[error] 	at aQute.bnd.osgi.Jar.<init>(Jar.java:109)
[error] 	at aQute.bnd.osgi.Jar.<init>(Jar.java:138)
[error] 	at aQute.bnd.osgi.Analyzer.setClasspath(Analyzer.java:1465)
[error] 	at com.typesafe.sbt.osgi.Osgi$.bundleTask(Osgi.scala:57)
[error] 	at com.typesafe.sbt.osgi.SbtOsgi$.$anonfun$defaultOsgiSettings$1(SbtOsgi.scala:55)
[error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error] 	at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
[error] 	at sbt.std.Transform$$anon$4.work(Transform.scala:68)
[error] 	at sbt.Execute.$anonfun$submit$2(Execute.scala:282)
[error] 	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:23)
[error] 	at sbt.Execute.work(Execute.scala:291)
[error] 	at sbt.Execute.$anonfun$submit$1(Execute.scala:282)
[error] 	at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[error] 	at sbt.CompletionService$$anon$2.call(CompletionService.scala:64)
[error] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error] 	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
[error] 	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error] 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
[error] 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
[error] 	at java.base/java.lang.Thread.run(Thread.java:833)
@pvlugter pvlugter added the failed Tickets that indicate a CI failure, likely a flakey test label Feb 17, 2022
@raboof raboof added the t:osgi label Feb 17, 2022
@patriknw
Copy link
Member

we could drop this test completely, or just for JDK 17. osgi is not a priority, #28304

@patriknw
Copy link
Member

ah, it's not a test but the actual build

@pvlugter
Copy link
Contributor Author

Yeah, this is the local publish step, which it's getting to after tests passing. Could not run the publish check for JDK 17?

patriknw added a commit that referenced this issue Feb 18, 2022
@patriknw
Don't test publishLocal with JDK 17, #31132
1f24587 
* JDK 17 builds are failing with ConcurrentModificationExceptions for the osgiBundle task
@patriknw patriknw mentioned this issue Feb 18, 2022
Merged
@patriknw
Copy link
Member

absolutely, created PR #31135 for that

patriknw added a commit that referenced this issue Feb 18, 2022
@patriknw
Don't test publishLocal with JDK 17, #31132 (#31135)
0ac1114 
* JDK 17 builds are failing with ConcurrentModificationExceptions for the osgiBundle task
@patriknw patriknw added this to the 2.6.19 milestone Feb 18, 2022
@patriknw
Copy link
Member

The issue is not really fixed, but we don't need to publish with JDK 17 (yet)

patriknw added a commit that referenced this issue Feb 18, 2022
@patriknw
Don't test publishLocal with JDK 17 - fix syntax error, #31132
f8520bc
@patriknw patriknw mentioned this issue Feb 18, 2022
Merged
patriknw added a commit that referenced this issue Feb 18, 2022
@patriknw @raboof
Don't test publishLocal with JDK 17 - fix syntax error, #31132 (#31136)
81349d6 
Co-authored-by: Arnout Engelen <arnout@bzzt.net>
@raboof raboof changed the title failed: osgiBundle task in JDK 17 builds Publishing with JDK17 fails due to sbt-osgi Mar 3, 2022
@raboof
Copy link
Member

raboof commented Mar 3, 2022

(since https://github.com/akka/akka/blob/main/.github/workflows/nightly-builds.yml#L206 points here, let's keep this issue open for eventually supporting publishing with jdk17)

@raboof raboof reopened this Mar 3, 2022
@raboof raboof mentioned this issue Mar 3, 2022
Merged
@patriknw patriknw added t:build and removed failed Tickets that indicate a CI failure, likely a flakey test labels Mar 8, 2022
@patriknw patriknw removed this from the 2.6.19 milestone Mar 18, 2022
This was referenced Jun 13, 2022
Closed
Closed
@raboof
Copy link
Member

raboof commented Jun 14, 2022 •
edited
Loading

this problem possibly has been fixed already between sbt-osgi 0.9.4 and 0.9.6, but we can't update yet due to #31437

@patriknw
Copy link
Member

Obsolete, see #28304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t:build t:osgi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pvlugter @raboof @patriknw