Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed: FileSink - must allow overriding the dispatcher using Attributes #31366

Closed
octonato opened this issue Apr 25, 2022 · 10 comments
Closed

failed: FileSink - must allow overriding the dispatcher using Attributes #31366

octonato opened this issue Apr 25, 2022 · 10 comments
Labels
failed Tickets that indicate a CI failure, likely a flakey test
Milestone
2.8.0-M4

Comments

@octonato
Copy link
Member

https://github.com/akka/akka/runs/6136665905?check_suite_focus=true#step:5:18418

[04-23 00:46:33.275] [info] - must allow overriding the dispatcher using Attributes *** FAILED *** (4 seconds, 11 milliseconds)
[04-23 00:46:33.276] [info]   java.lang.AssertionError: Expected Actor[akka://FileSinkSpec/system/Materializers/StreamSupervisor-1840/flow-20-2-fileSink#158914944] to use dispatcher [akka.actor.default-dispatcher], yet used: [akka.stream.materializer.blocking-io-dispatcher]
[04-23 00:46:33.276] [info]   at akka.stream.testkit.Utils$.assertDispatcher(Utils.scala:26)
[04-23 00:46:33.277] [info]   at akka.stream.io.FileSinkSpec.$anonfun$new$27(FileSinkSpec.scala:192)
[04-23 00:46:33.277] [info]   at akka.stream.io.FileSinkSpec.$anonfun$new$27$adapted(FileSinkSpec.scala:182)
[04-23 00:46:33.277] [info]   at akka.stream.io.FileSinkSpec.targetFile(FileSinkSpec.scala:244)
[04-23 00:46:33.279] [info]   at akka.stream.io.FileSinkSpec.$anonfun$new$26(FileSinkSpec.scala:182)
[04-23 00:46:33.279] [info]   at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.scala:18)
[04-23 00:46:33.279] [info]   at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[04-23 00:46:33.279] [info]   at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
[04-23 00:46:33.279] [info]   at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[04-23 00:46:33.279] [info]   at org.scalatest.Transformer.apply(Transformer.scala:22)
[04-23 00:46:33.279] [info]   at org.scalatest.Transformer.apply(Transformer.scala:20)
@octonato octonato added the failed Tickets that indicate a CI failure, likely a flakey test label Apr 25, 2022
@pvlugter
Copy link
Contributor

https://github.com/akka/akka/runs/6547186775?check_suite_focus=true#step:5:19066

@johanandren
Copy link
Member

https://github.com/akka/akka/runs/6680658837?check_suite_focus=true#step:5:18904

Strange that this started failing all of a sudden, shouldn't be a race condition if the dispatcher is right or not....

@johanandren
Copy link
Member

https://github.com/akka/akka/runs/6741586379?check_suite_focus=true

@pvlugter
Copy link
Contributor

https://github.com/akka/akka/runs/6846529522?check_suite_focus=true#step:5:18246

@pvlugter
Copy link
Contributor

https://github.com/akka/akka/runs/6944430648?check_suite_focus=true#step:5:18579

@johanandren
Copy link
Member

https://github.com/akka/akka/runs/7083637091?check_suite_focus=true#step:5:18369

@patriknw
Copy link
Member

https://github.com/akka/akka/runs/7830220918?check_suite_focus=true#step:5:18500

@pvlugter
Copy link
Contributor

pvlugter commented Sep 5, 2022

https://github.com/akka/akka/runs/8172943647?check_suite_focus=true#step:5:18670

@johanandren johanandren mentioned this issue Sep 14, 2022
Open
@pvlugter
Copy link
Contributor

https://github.com/akka/akka/actions/runs/3257655849/jobs/5349063878#step:5:19021

@pvlugter
Copy link
Contributor

pvlugter commented Dec 5, 2022

https://github.com/akka/akka/actions/runs/3615722687/jobs/6093014148#step:5:5610

johanandren added a commit to johanandren/akka that referenced this issue Jan 9, 2023
@johanandren
fix: Failures in tests verifying stream io dispatcher use akka#31366
d1fb40c 
Avoid creating a materializer in tests that wants to check dispatcher as a custom
materializer is not covered by the stream stopping between test cases in StreamSpec

Also cleans up some code in StreamSpec that wasn't working since a while back.
@johanandren johanandren mentioned this issue Jan 9, 2023
Merged
johanandren added a commit that referenced this issue Jan 10, 2023
@johanandren
fix: Failures in tests verifying stream io dispatcher use #31366 (#31812
145319d 
)

Avoid creating a materializer in tests that wants to check dispatcher as a custom
materializer is not covered by the stream stopping between test cases in StreamSpec

Also cleans up some code in StreamSpec that wasn't working since a while back.
@johanandren johanandren added this to the 2.8.0-M4 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failed Tickets that indicate a CI failure, likely a flakey test
Projects
None yet
Milestone
2.8.0-M4
Development

No branches or pull requests
4 participants
@pvlugter @patriknw @octonato @johanandren