Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecation of Flow#recoverWith #31670

Closed
He-Pin opened this issue Oct 15, 2022 · 0 comments
Closed

Remove the deprecation of Flow#recoverWith #31670

He-Pin opened this issue Oct 15, 2022 · 0 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:stream
Milestone

Comments

@He-Pin
Copy link
Member

He-Pin commented Oct 15, 2022

As working on #31639 and #31669, I found that the recoverWith is deprecated. when digging further, I think it's a mistaken to deprecate it and we should remove the deprecation.

And in issue #24992, @patriknw pointed out that:

By the way, I suggest removing the deprecation of recoverWith since I think in most of the time the attempt count is not interesting, especially since there is no reset of the count or notion of failures per time unit.

As for the change, I think the only change need to do is just updated the java/scala doc about if you prefer to limit the maximum retring times, use RecoverWithRetries.

@johanandren johanandren added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:stream labels Feb 7, 2023
@johanandren johanandren added this to the 2.8.0-M6 milestone Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:stream
Projects
None yet
Development

No branches or pull requests

2 participants