Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to slf4j 2.0 #32364

Open
patriknw opened this issue Mar 25, 2024 · 2 comments
Open

Update to slf4j 2.0 #32364

patriknw opened this issue Mar 25, 2024 · 2 comments
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted dependency-change

Comments

@patriknw
Copy link
Member

Sl4fj 2.0 is not fully backwards compatible. We made a workaround in #31825 to make it work with both. We have been holding back to update the dependency to 2.0 so that Akka wouldn't enforce all downstream projects to bump to later slf4j.

Sooner or later we will have to update, but no decision on when we will do that yet. Important that we make that change in all Akka projects at the same time to avoid confusion.

We have already seen that 2.0 is brought in by transitive dependencies of external libraries. akka-persistence-jdbc and the Slick dependency is one such, and we pinned slf4j to 1.7.36. Remember to remove that when we update.

@patriknw patriknw added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted dependency-change labels Mar 25, 2024
@patriknw
Copy link
Member Author

another pin in Akka Projections due to the Slick dependency

@johanandren
Copy link
Member

And one more in akka-persistence-r2dbc (only migration tool tests though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted dependency-change
Projects
None yet
Development

No branches or pull requests

2 participants