docs: SLF4J API incompability docs #32390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Apr 19, 2024
| ## SLF4J API compatibility | ||
|
|
||
| The SLF4J API broke binary compatibility between versions 1.7 and 2.0. Akka supports SLF4J 1.7 however many libraries | ||
| and logger backends have upgraded to SLF4J 2.0 which will cause problems if introduced in an Akka project. |
There was a problem hiding this comment.
Is that really the case? Isn't the main problem when using incompatible slf4j-api and logger impl (logback) dependencies?
I thought it would still work if bumping both api and impl to a compatible latest version?
There was a problem hiding this comment.
You are right, I verified. Updated to cover both options but maybe we should just recommend bumping logging backend instead?
octonato
reviewed
Apr 19, 2024
octonato
approved these changes
Apr 19, 2024
Co-authored-by: Renato Cavalcanti <renato@cavalcanti.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.