DOC: correct wrong advice in 'Routers and Supervision', see #3484 #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
Jul 1, 2013
patriknw
commented
- and clarify default restart behavior more
| @@ -131,15 +131,17 @@ turn, will cause its children to stop and restart. | |||
| It should be mentioned that the router's restart behavior has been overridden so that a restart, | |||
| while still re-creating the children, will still preserve the same number of actors in the pool. | |||
|
|
|||
| This means that if you have not specified :meth:`supervisorStrategy` of the router or its parent a | |||
| failure in a routee will escalate to the parent of the router, which will by default restart the router, | |||
There was a problem hiding this comment.
Maybe add something like "In other words the default strategy is Escalate"
There was a problem hiding this comment.
yes, append in parentheses to the end of the sentence that it uses Escalate and does not stop routees during restart
|
LGTM |
* and clarify default restart behavior more
|
adjusted according to suggestion |
|
This is ready for merge, and backport to release-2.2 |
rkuhn
added a commit
that referenced
this pull request
Jul 4, 2013
…triknw DOC: correct wrong advice in 'Routers and Supervision', see #3484
|
backported to release-2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.