Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=str #16787 java cookbook #16850

Closed
wants to merge 1 commit into from
Closed

=str #16787 java cookbook #16850

wants to merge 1 commit into from

Conversation

ktoso
Copy link
Member

@ktoso ktoso commented Feb 11, 2015

Missing a few recipes, I'm adding them now.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Feb 11, 2015
@akka-ci
Copy link

akka-ci commented Feb 11, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/1912/

@akka-ci akka-ci removed the validating PR is currently being validated by Jenkins label Feb 11, 2015
@ktoso ktoso force-pushed the wip-java-cooking-ktoso branch 2 times, most recently from e98133c to 4b2f470 Compare February 11, 2015 11:52
@akka-ci akka-ci added validating PR is currently being validated by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Feb 11, 2015
@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels Feb 11, 2015
@akka-ci
Copy link

akka-ci commented Feb 11, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/1914/

@ktoso
Copy link
Member Author

ktoso commented Feb 11, 2015

Pushed fixup of mock System.out.println() which caused test failures. Ready to be reviewed now.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Feb 11, 2015
@ktoso ktoso changed the title =str #16787 WIP java cookbook =str #16787 java cookbook Feb 11, 2015
@ktoso
Copy link
Member Author

ktoso commented Feb 11, 2015

refs #16787

@akka-ci akka-ci added needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels Feb 11, 2015
@akka-ci
Copy link

akka-ci commented Feb 11, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/1915/

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Feb 11, 2015
@akka-ci
Copy link

akka-ci commented Feb 11, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/1916/

@akka-ci akka-ci removed the validating PR is currently being validated by Jenkins label Feb 11, 2015
@ktoso
Copy link
Member Author

ktoso commented Feb 11, 2015

failure was pdf generation - file include was wrong in one spot s/seq/list/

@akka-ci akka-ci added the validating PR is currently being validated by Jenkins label Feb 11, 2015
@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels Feb 11, 2015
@akka-ci
Copy link

akka-ci commented Feb 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/1917/

patriknw
patriknw reviewed Feb 17, 2015
View reviewed changes
akka-actor/src/main/scala/akka/util/ByteString.scala
* Creates a new ByteString by copying an int array by converting from integral numbers to bytes.
*/
@varargs
def fromInts(array: Int*): ByteString =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be changed here, but in release-2.3 branch

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right - thanks!

@ktoso
Copy link
Member Author

ktoso commented Feb 24, 2015

Moved over to drewhk#22, applied Patriks comments.

@ktoso ktoso mentioned this pull request Feb 25, 2015
Merged
@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed tested PR that was successfully built and tested by Jenkins validating PR is currently being validated by Jenkins labels Mar 31, 2015
@akka-ci
Copy link

akka-ci commented Mar 31, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/2186/

@rkuhn rkuhn closed this May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-attention Indicates a PR validation failure (set by CI infrastructure)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ktoso @akka-ci @patriknw @rkuhn