do not generate javadoc for tests #17528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -313,7 +313,8 @@ object AkkaBuild extends Build { | |||
| // compile options | |||
| scalacOptions in Compile ++= Seq("-encoding", "UTF-8", "-target:jvm-1.8", "-feature", "-unchecked", "-Xlog-reflective-calls", "-Xlint"), | |||
| scalacOptions in Compile ++= (if (allWarnings) Seq("-deprecation") else Nil), | |||
| scalacOptions in Test := (scalacOptions in Test).value.filterNot(_ == "-Xlog-reflective-calls"), | |||
| scalacOptions in Test := (scalacOptions in Test).value.filterNot(opt => | |||
| opt == "-Xlog-reflective-calls" || opt.contains("genjavadoc")), | |||
There was a problem hiding this comment.
No, not at all: we previously added the configuration that emits the synthetic Java sources to the Test configuration, now we don’t.
There was a problem hiding this comment.
where do we add this opt to scalacOptions in the first place?
I can't find the string "genjavadoc" anywhere else than scalacOptions in Compile += "-P:genjavadoc:fabricateParams=true", but that can't be the thing.
Is it added by unidoc?
There was a problem hiding this comment.
Yes, it is in genjavadocExtraSettings, pulled in from project/Unidoc.scala.
|
LGTM, thanks |
|
Test PASSed. |
patriknw
added a commit
that referenced
this pull request
May 20, 2015
do not generate javadoc for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.