Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=doc code snippet include in persistence docs (scala) was broken #18298

Merged
merged 1 commit into from Aug 24, 2015

Conversation

ktoso
Copy link
Member

@ktoso ktoso commented Aug 23, 2015

Without this the import imports from the next line to "end of file".

@ktoso
Copy link
Member Author

ktoso commented Aug 23, 2015

We should consider re-uploading the docs after this fix is merged

@ktoso ktoso added the t:docs label Aug 23, 2015
@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Aug 23, 2015
@akka-ci
Copy link

akka-ci commented Aug 23, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.akka.io/job/pr-validator-per-commit-jenkins/3494/

@patriknw
Copy link
Member

LGTM, but I don't see the urgency to patch the published docs

@ktoso
Copy link
Member Author

ktoso commented Aug 24, 2015

Okey, merging - may want to update them once #18306 fixed though.

ktoso added a commit that referenced this pull request Aug 24, 2015
…toso

=doc code snippet include in persistence docs (scala) was broken
@ktoso ktoso merged commit 413c956 into akka:master Aug 24, 2015
@ktoso ktoso deleted the wip-fix-in-persistence-include-ktoso branch August 24, 2015 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:docs tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants