=doc #3886 improved example of PartialFunction.orElse composition #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``PartialFunction.orElse`` chaining. | ||
| Sometimes it can be useful to share common behavior among a few actors, or compose one actor's behavior from multiple smaller functions. | ||
| This is is possible because an actor's :meth:`receive` method returns an ``Actor.Receive``, which is a type alias for ``PartialFunction[Any,Unit]``, | ||
| and partial functions can be chained together using the ``PartialFunction#orElse`` method. You can chain however many functions you need, |
There was a problem hiding this comment.
You can chain however many functions you need, however ...
how about
You can chain as many functions as you need, however ...
?
| Sometimes it can be useful to share common behavior among a few actors, or compose one actor's behavior from multiple smaller functions. | ||
| This is is possible because an actor's :meth:`receive` method returns an ``Actor.Receive``, which is a type alias for ``PartialFunction[Any,Unit]``, | ||
| and partial functions can be chained together using the ``PartialFunction#orElse`` method. You can chain as many functions you need, | ||
| however you should keep in mind that "first match" wins - which may be important when combining functions that both can handle the same type of parameter. |
|
LGTM, thanks for the improvement! Doc fixes can still go in for 2.3.0. |
Changed orElse composition example to better highlight it's possibilities. This is a follow up PR based on a discussion on akka-user: https://groups.google.com/forum/#!topic/akka-user/vVUZPMeJmzw
|
LGTM |
|
Cool, feedback addressed and squashed :) |
|
LGTM, thanks |
|
Great job. Thanks @ktoso. |
rkuhn
added a commit
that referenced
this pull request
Feb 27, 2014
=doc #3886 improved example of PartialFunction.orElse composition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
PartialFunction#orElsecomposition example to better highlight it's possibilities.This is a follow up to a discussion on akka-user: https://groups.google.com/forum/#!topic/akka-user/vVUZPMeJmzw
Opened issue for this here: https://www.assembla.com/spaces/akka/simple_planner#/ticket:3886
Existing docs: http://doc.akka.io/docs/akka/snapshot/scala/actors.html#Extending_Actors_using_PartialFunction_chaining