=htc #20236 enable streaming responses with Connection: close
#20254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the repo owners verify this patch? |
|
OK TO TEST |
|
LGTM, awesome catch - thanks a lot @2Beaucoup ! |
akka-ci
added
validating
|
Test PASSed. |
| @@ -169,21 +169,17 @@ private[http] object OutgoingConnectionBlueprint { | |||
| private def entitySubstreamStarted = entitySource ne null | |||
| private def idle = this | |||
| private var completionDeferred = false | |||
| private var completeOnMessageEnd = false | |||
There was a problem hiding this comment.
Couldn't the existing boolean field be used for both completion scenarios? (doesn't matter much, just curious)
There was a problem hiding this comment.
Thought about that too but wasn't sure if completionDeferred is guaranteed to be set after completeOnMessageEnd. completionDeferred |= closeRequested should work though.
|
LGTM |
|
Thanks again! On 7 April 2016 at 18:39:46, Johan Andrén (notifications@github.com) wrote: LGTM — |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20236
/cc @sirthias