Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=pro sbt-0.13.2-RC1 with name hashing, scala 2.10.4 #2060

Merged
merged 1 commit into from Apr 14, 2014
Merged

=pro sbt-0.13.2-RC1 with name hashing, scala 2.10.4 #2060

merged 1 commit into from Apr 14, 2014

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Mar 7, 2014

  • take advantage of latest incremental compiler improvements

One data point. Compiling akka-actor after adding a new method in the Actor trait.

sbt 0.13.1:

akka-actor > compile
[info] Formatting 1 Scala source {file:/Users/patrik/tmp/akka/}akka-actor(compile) ...
[info] Compiling 1 Scala source to /Users/patrik/tmp/akka/akka-actor/target/classes...
[info] Compiling 113 Scala sources and 21 Java sources to /Users/patrik/tmp/akka/akka-actor/target/classes...
[success] Total time: 12 s, completed Mar 7, 2014 9:41:49 AM

sbt 0.13.2-M2:

akka-actor > compile
[info] Formatting 1 Scala source {file:/Users/patrik/dev/akka/}akka-actor(compile) ...
[info] Compiling 1 Scala source to /Users/patrik/dev/akka/akka-actor/target/classes...
[info] Compiling 46 Scala sources and 4 Java sources to /Users/patrik/dev/akka/akka-actor/target/classes...
[success] Total time: 8 s, completed Mar 7, 2014 9:40:52 AM

@patriknw patriknw mentioned this pull request Mar 7, 2014
Closed
@patriknw
Copy link
Member Author

We will wait for next release of sbt before using this.

@drewhk
Copy link
Member

drewhk commented Mar 10, 2014

Can't wait to have this!

@rkuhn
Copy link
Contributor

rkuhn commented Mar 11, 2014

since 0.13.2-M3 is out, does that contain all the needed fixes?

@patriknw patriknw mentioned this pull request Mar 12, 2014
Closed
@patriknw patriknw changed the title =pro sbt-0.13.2-M2 with name hashing =pro sbt-0.13.2-RC1 with name hashing, scala 2.10.4 Mar 25, 2014
@patriknw
Copy link
Member Author

rebased this, and changed to sbt-0.13.2-RC1, and scala 2.10.4

@patriknw
Copy link
Member Author

we need genjavadoc for 2.10.4
the failure: unresolved dependency: com.typesafe.genjavadoc#genjavadoc-plugin_2.10.4;0.5: not found

@bantonsson
Copy link
Member

@patriknw The instructions for publishing genjavadoc are on the wiki 😉

@patriknw
Copy link
Member Author

PLS REBUILD/pr-validator-per-commit@53a5d7c

@rkuhn
Copy link
Contributor

rkuhn commented Mar 27, 2014

BTW: genjavadoc-plugin_2.10.4 has been published

@patriknw
Copy link
Member Author

yes, I saw that, and that was the reason to rebuild -- thanks

@akka-ci
Copy link

akka-ci commented Mar 27, 2014

(kitty-note-to-self: ignore 38795131)
🐱 Roger! Rebuilding pr-validator-per-commit for 53a5d7c. 🚨

@patriknw
Copy link
Member Author

We must investigate the failures before merging this pr: https://www.assembla.com/spaces/akka/simple_planner#/ticket:3984

@patriknw
=pro sbt-0.13.2-RC2 with name hashing, scala 2.10.4
f677ed0 
* take advantage of latest incremental compiler improvements
* scala 2.10.4
* Remove workaround in FutureSpec, bug fixed in Scala 2.10.4
* Change version of samples to allow snapshot overwrite in publishM2
* allow publish overwrite for osgi-dining-hakkers/uncommons
@patriknw
Copy link
Member Author

I fixed the failure in FutureSpec, it was a workaround for an issue that is fixed in Scala 2.10.4

@bantonsson
Copy link
Member

LGTM

@patriknw
Copy link
Member Author

Yay, can't wait to use this. Merge?

@drewhk
Copy link
Member

drewhk commented Apr 11, 2014

LGTM

1 similar comment
@bantonsson
Copy link
Member

LGTM

patriknw added a commit that referenced this pull request Apr 14, 2014
@patriknw
Merge pull request #2060 from akka/wip-sbt-name-hashing-patriknw
d3b7320 
=pro sbt-0.13.2-RC1 with name hashing, scala 2.10.4
@patriknw patriknw merged commit d3b7320 into master Apr 14, 2014
@patriknw patriknw deleted the wip-sbt-name-hashing-patriknw branch April 14, 2014 11:19
@patriknw patriknw mentioned this pull request Apr 15, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
reviewed Ready to merge from review perspetive, but awaiting some additional action (e.g. order of merges) tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@patriknw @drewhk @rkuhn @bantonsson @akka-ci