+htp #18837 JSON framing and framed entity streaming directives #20778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test FAILed. |
| } | ||
|
|
||
| /** | ||
| * Simple rendering mode, similar to [[Compact]] however interspersing elements with a `\n` character. |
There was a problem hiding this comment.
\n makes it nicely formatted though
|
LGTM |
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
|
Test FAILed. |
ktoso
force-pushed
the
revival-of-the-undead-json-streaming-of-doom-ktoso
branch
from
39d6b17
to
d2e47c0
Compare
akka-ci
added
validating
|
Test PASSed. |
|
This is finally complete, including javadsl and documentation (after oh-so-many-years). |
|
Test FAILed. |
akka-ci
added
validating
|
Very weird timeout... I blame jenkins :/ |
akka-ci
added
needs-attention
|
Test FAILed. |
akka-ci
added
validating
| * This is achieved by applying the implicitly provided (in the following order): | ||
| * | ||
| * - 1st: [[FramingFlow]] in order to chunk-up the incoming [[ByteString]]s according to the | ||
| * `Content-Type` aware framing (for example, [[common.EntityStreamingSupport.bracketCountingJsonFraming]]). |
There was a problem hiding this comment.
bracketCountingJsonFraming?
akka-ci
added
needs-attention
|
Test FAILed. |
added CSV examples updated docs EntityStreamingSupport is now an entry point, to all streaming things both read and write side use it it's easy to extend as well
ktoso
force-pushed
the
revival-of-the-undead-json-streaming-of-doom-ktoso
branch
from
5e50bde
to
da23f6d
Compare
ktoso
force-pushed
the
revival-of-the-undead-json-streaming-of-doom-ktoso
branch
from
da23f6d
to
8a1f8f2
Compare
|
The only failures were in a specific JsonFraming spec - those were legitimate bugs in completion handline exposed only after the new Interpreter changes were merged. No other test failures in sight. I shall merge thee. |
|
Thanks everyone for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival of framed entity streaming.
Missing:
Resolves #18837 (honestly every HTTP demo I see wants this, also @RayRoestenburg's book 😉 )
Maybe this time it will get some review attention 😉