=per #3915 Make become work during recovery for EventsourcedProcessor et.c.

[bantonsson]

No description provided.

[patriknw]

excellent

[patriknw]

LGTM

[patriknw]

@bantonsson one more thing; the ExampleProcessor in the docs is not correct. It doesn't do become in receiveRecover. I think that example should be simplified, not use become. Too many things. Instead we should mention in the docs that become is supported, and perhaps have a separate example of it.

[bantonsson]

@patriknw, yes I know. It can end up i n the wrong state during recovery. I'll remove that and add it to the docs instead.

[bantonsson]

Updated the doc and samples. Also added the necessary things to the lambda sample for it to become an activator tutorial.

[patriknw]

this should be changed to Akka Persistence Samples in Java with Lambdas
I created a reminder to update the download page.

[bantonsson]

Nice catch. Thanks.

[drewhk]

LGTM

[rkuhn]

So if I understand correctly, receiveRecover is now always used during recovery, regardless of calls to context.become(); outside of recovery the processing behavior can be changed, where receiveCommand relates to the become arguments just like receive normally does. One question which might warrant a comment: is it possible to get SnapshotOffer or RecoveryFailure outside of recovery? In that case a become argument would have to handle these as well, which is not true for receiveCommand in conjunction with initialBehavior.

This separation seems like it might want to be simplified—or I am just confused and should read the docs with a bit more time.

Apart from this, it LGTM for now.

[bantonsson]

@rkuhn, It's not possible to get SnapshotOffer or RecoveryFailure outside of recovery. The reason that it's safe to only use receiveRecover and is not visible in the diff is that the EventSourced.super.aroundReceive will stash all messages that are not related to the recovery.

Yes, the logic is convoluted. I don't want to touch it before 2.3.1, but I created a ticket.