[#21090] Added the improved code for loggingResponsetime and added the link in the docs #21118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the link in the docs
|
Can one of the repo owners verify this patch? |
|
@ktoso @johanandren : Can we merge this ? Please assign it in testing ! |
|
I think the counterpart of Java DSL needs this example too. You can look into the |
|
@Hawstein : I have added the javadocs and code too . Please take a look |
| if(response.status().isSuccess()) | ||
| { | ||
| Long elapsedTime=(requestTime - System.nanoTime()) / 1000; |
There was a problem hiding this comment.
If you wanted it in microseconds, one microsecond is 1 000 000 nanoseconds
|
OK TO TEST |
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
akka-ci
added
validating
|
LGTM! |
akka-ci
added
validating
|
Test PASSed. |
|
|
||
| // handle request to optionally generate a log entry | ||
|
|
|
LGTM after last round of comments addressed, thanks |
akka-ci
added
validating
|
Test PASSed. |
akka-ci
added
validating
| @@ -30,3 +30,13 @@ Example | |||
|
|
|||
| .. includecode2:: ../../../../code/docs/http/scaladsl/server/directives/DebuggingDirectivesExamplesSpec.scala | |||
| :snippet: logRequestResult | |||
|
|
|||
|
|
|||
| Building Advanced Directives | |||
|
LGTM, thanks for your work on this. |
ktoso
added
the
reviewed
|
Test PASSed. |
|
Resolves #21090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the improved code as per the comments on #21110 .