Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=str #21926 add note on (non)guarantees of materializer SPI #21932

Merged
merged 1 commit into from Dec 2, 2016
Merged

=str #21926 add note on (non)guarantees of materializer SPI #21932

merged 1 commit into from Dec 2, 2016

Conversation

ktoso
Copy link
Member

@ktoso ktoso commented Dec 2, 2016

Resolves #21926

And I'd backport this note to 2.4 as well.

patriknw
patriknw approved these changes Dec 2, 2016
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akka-ci akka-ci added the validating PR is currently being validated by Jenkins label Dec 2, 2016
@ktoso ktoso merged commit 726d3c4 into akka:master Dec 2, 2016
ktoso added a commit that referenced this pull request Dec 2, 2016
@ktoso
=str #21926 add note on (non)guarantees of materializer SPI (#21932)
51104f2
ktoso added a commit that referenced this pull request Dec 2, 2016
@ktoso
=str #21926 add note on (non)guarantees of materializer SPI (#21932)
ad84ba5
@ktoso ktoso mentioned this pull request Dec 2, 2016
Merged
@akka-ci akka-ci added the tested PR that was successfully built and tested by Jenkins label Dec 2, 2016
@akka-ci
Copy link

akka-ci commented Dec 2, 2016

Test PASSed.

@akka-ci akka-ci removed the validating PR is currently being validated by Jenkins label Dec 2, 2016
@ktoso ktoso deleted the materializer-api-note branch December 2, 2016 11:22
ktoso added a commit that referenced this pull request Dec 2, 2016
@ktoso
=str #21926 add note on (non)guarantees of materializer SPI (#21932) (#…
cc46d15 
…21935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ktoso @akka-ci @patriknw @johanandren