Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customise test for race between GetState message and persistAsync handler #22065

Closed
wants to merge 115 commits into from

Conversation

ortibazar
Copy link
Contributor

In this failure, updateState handler in persistAsync(Evt("rc-3"))(updateState) processed before GetState message. And there is also chance GetState message handler may execute before this handler. So the result message may contain "rc-3" or not.

Refs #22052

@akka-ci
Copy link

akka-ci commented Dec 24, 2016

Can one of the repo owners verify this patch?

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@patriknw
Copy link
Member

patriknw commented Jan 9, 2017

OK TO TEST

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Jan 10, 2017
@patriknw
Copy link
Member

PLS BUILD

Ben Fonarov and others added 18 commits January 10, 2017 14:11
- All Map types are now generic in their key: ORMap, ORMultiMap, LWWMap,
  PNCounterMap
- test for binary compatibility with previous version for serialization
- entries are sorted for deterministic SHA-1 on same value
…e_generic_type-jgordijn

akka#22035  Make it possible to use anything as the key in a map
Remove redundant new modifier
Also
* add InternalApi annotation to AESCounterBuiltinRNG
* add setDaemon(true) to re-seeder thread
* WIP early preview of moving compressions ownership to Decoder

* Compression table created in transport, but owned by Decoder
Added test for restart of inbound stream

* =art snapshot not needed in HeavyHitters since owned by Decoder
…des_in_consistency-jgordijn

akka#21648 Prefer reachable nodes in consistency writes/reads
* CoordinatedShutdown that can run tasks for configured phases in order (DAG)
* coordinate handover/shutdown of singleton with cluster exiting/shutdown
* phase config obj with depends-on list
* integrate graceful leaving of sharding in coordinated shutdown
* add timeout and recover
* add some missing artery ports to tests
* leave via CoordinatedShutdown.run
* optionally exit-jvm in last phase
* run via jvm shutdown hook
* send ExitingConfirmed to leader before shutdown of Exiting
  to not have to wait for failure detector to mark it as
  unreachable before removing
* the unreachable signal is still kept as a safe guard if
  message is lost or leader dies
* PhaseClusterExiting vs MemberExited in ClusterSingletonManager
* terminate ActorSystem when cluster shutdown (via Down)
* add more predefined and custom phases
* reference documentation
* migration guide
* problem when the leader order was sys2, sys1, sys3,
  then sys3 could not perform it's duties and move Leving sys1 to
  Exiting because it was observing sys1 as unreachable
* exclude Leaving with exitingConfirmed from convergence condidtion
* The reason is to have a consistent approach for Sequence and
  TimeBasedUUID, which are both intended as unique event identifiers.
* This means that you can use the offset that is returned in `EventEnvelope`
  as the `offset` parameter in a subsequent query.
patriknw and others added 23 commits January 25, 2017 07:20
* because with Scala 2.12 it can't infer the right overload
* prefer the `() =>`, but here it's clear that it's a callback
* similar in ActorSystem.registerOnTermination
…kka#22169

* because it's sending a dummy `Failed` sys msg with `null` child
…ult-patriknw

Use ddata mode as the default for Cluster Sharding, akka#17963
…iknw

Enable additional-serialization-bindings by default, akka#22169
use minCap for majority write/read in sharding, akka#22141
handle IllegalStateException in CoordinatedShutdown
Fix metrics documentation + some typos
temorary disable additional-serializers for ReliableProxySpec, akka#22224
* assertion failed: block took 583.856 milliseconds, should at least have been 600 milliseconds
adjust time assertion in TestConductorSpec
rolling update considerations in migration guide
* can't make the dependency provided or test and still be able
  to compile/run tests
* might not be a big deal to include the persistence dependency instead
@patriknw
Copy link
Member

yeah, I had some of those also. I solved it by pushing a new commit (rebasing with master)

@ortibazar
Copy link
Contributor Author

I'll create new pull request

@ortibazar ortibazar closed this Jan 26, 2017
@ktoso
Copy link
Member

ktoso commented Jan 26, 2017

This seems like a rebase gone wrong @ortigali ?

Okey, thanks

@ortibazar ortibazar deleted the wip-22052-PersistentActorSpec branch January 26, 2017 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet