-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customise test for race between GetState message and persistAsync handler #22065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the repo owners verify this patch? |
patriknw
approved these changes
Jan 9, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good catch
OK TO TEST |
…atriknw stop ClusterClient ResponseTunnel after first reply when ask is used, akka#22093
patriknw
added
the
2 - pick next
Used to mark issues which are next up in the queue to be worked on. The tag is non-binding
label
Jan 10, 2017
PLS BUILD |
…ernative-random AES-CTR with re-seeding (akka#21740)
- All Map types are now generic in their key: ORMap, ORMultiMap, LWWMap, PNCounterMap - test for binary compatibility with previous version for serialization - entries are sorted for deterministic SHA-1 on same value
…e_generic_type-jgordijn akka#22035 Make it possible to use anything as the key in a map
Remove redundant new modifier
Also * add InternalApi annotation to AESCounterBuiltinRNG * add setDaemon(true) to re-seeder thread
* WIP early preview of moving compressions ownership to Decoder * Compression table created in transport, but owned by Decoder Added test for restart of inbound stream * =art snapshot not needed in HeavyHitters since owned by Decoder
…des_in_consistency-jgordijn akka#21648 Prefer reachable nodes in consistency writes/reads
* CoordinatedShutdown that can run tasks for configured phases in order (DAG) * coordinate handover/shutdown of singleton with cluster exiting/shutdown * phase config obj with depends-on list * integrate graceful leaving of sharding in coordinated shutdown * add timeout and recover * add some missing artery ports to tests * leave via CoordinatedShutdown.run * optionally exit-jvm in last phase * run via jvm shutdown hook * send ExitingConfirmed to leader before shutdown of Exiting to not have to wait for failure detector to mark it as unreachable before removing * the unreachable signal is still kept as a safe guard if message is lost or leader dies * PhaseClusterExiting vs MemberExited in ClusterSingletonManager * terminate ActorSystem when cluster shutdown (via Down) * add more predefined and custom phases * reference documentation * migration guide * problem when the leader order was sys2, sys1, sys3, then sys3 could not perform it's duties and move Leving sys1 to Exiting because it was observing sys1 as unreachable * exclude Leaving with exitingConfirmed from convergence condidtion
add CoordinatedShutdown, akka#21537
* The reason is to have a consistent approach for Sequence and TimeBasedUUID, which are both intended as unique event identifiers. * This means that you can use the offset that is returned in `EventEnvelope` as the `offset` parameter in a subsequent query.
disable weakly-up for some tests
* because with Scala 2.12 it can't infer the right overload * prefer the `() =>`, but here it's clear that it's a callback * similar in ActorSystem.registerOnTermination
…kka#22169 * because it's sending a dummy `Failed` sys msg with `null` child
Change signature of addJvmShutdownHook
…ult-patriknw Use ddata mode as the default for Cluster Sharding, akka#17963
…iknw Enable additional-serialization-bindings by default, akka#22169
use minCap for majority write/read in sharding, akka#22141
fix some compilation warnings
handle IllegalStateException in CoordinatedShutdown
Fix metrics documentation + some typos
temorary disable additional-serializers for ReliableProxySpec, akka#22224
* assertion failed: block took 583.856 milliseconds, should at least have been 600 milliseconds
* Release script updates
adjust time assertion in TestConductorSpec
rolling update considerations in migration guide
* can't make the dependency provided or test and still be able to compile/run tests * might not be a big deal to include the persistence dependency instead
fix sharding dependency to persistence
yeah, I had some of those also. I solved it by pushing a new commit (rebasing with master) |
…kka into wip-22052-PersistentActorSpec
I'll create new pull request |
This seems like a rebase gone wrong @ortigali ? Okey, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2 - pick next
Used to mark issues which are next up in the queue to be worked on. The tag is non-binding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this failure, updateState handler in
persistAsync(Evt("rc-3"))(updateState)
processed before GetState message. And there is also chance GetState message handler may execute before this handler. So the result message may contain "rc-3" or not.Refs #22052