Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

customise test for race between GetState and persistAsync handler #22052 (for validation) #22355

Merged
merged 2 commits into from Feb 22, 2017
Merged

customise test for race between GetState and persistAsync handler #22052 (for validation) #22355

merged 2 commits into from Feb 22, 2017

Conversation

patriknw
Copy link
Member

(cherry picked from commit 5ee25d9)

Refs #22052

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels Feb 21, 2017
@akka-ci
Copy link

akka-ci commented Feb 21, 2017

Test FAILed.

@patriknw
Copy link
Member Author

@ortigali This is a backport of your PR. It failed PR validation. I guess same thing can happen in master. Could you look at this failure?

[info] - must be able to persist events that happen during recovery *** FAILED *** (12 milliseconds)
[info]   java.lang.AssertionError: assertion failed: found unexpected List(a-1, a-2)
[info]   at scala.Predef$.assert(Predef.scala:170)
[info]   at akka.testkit.TestKitBase$class.expectMsgAnyOf_internal(TestKit.scala:494)
[info]   at akka.testkit.TestKitBase$class.expectMsgAnyOf(TestKit.scala:480)
[info]   at akka.testkit.TestKit.expectMsgAnyOf(TestKit.scala:814)
[info]   at akka.persistence.PersistentActorSpec$$anonfun$1$$anonfun$apply$mcV$sp$44.apply(PersistentActorSpec.scala:1157)
[info]   at akka.persistence.PersistentActorSpec$$anonfun$1$$anonfun$apply$mcV$sp$44.apply(PersistentActorSpec.scala:1154)
[info]   at org.scalatest.OutcomeOf$class.outcomeOf(OutcomeOf.scala:85)

@ortibazar
Copy link
Contributor

It depends on this PR #21893, but it was not backported to 2.4 branch. Ktoso told about it here

ortigali added 2 commits February 21, 2017 15:37
@patriknw
=per Allow persisting events when recovery has completed (#21893)
bff6135 
* be able to persist events that happen during recovery, #21736

* prohibit persiting events during recovery, #21736

* change error message #21736

(cherry picked from commit ef1e0e0)
@patriknw
customise test for race between GetState and persistAsync handler #22052
2995501 


(cherry picked from commit 5ee25d9)
@patriknw
Copy link
Member Author

I see, I have included that in this PR.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) labels Feb 21, 2017
@akka-ci
Copy link

akka-ci commented Feb 21, 2017

Test PASSed.

@akka-ci akka-ci removed the validating PR is currently being validated by Jenkins label Feb 21, 2017
@patriknw patriknw merged commit d333d87 into release-2.4 Feb 22, 2017
@patriknw patriknw deleted the wip-22052-2.4-patriknw branch February 22, 2017 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patriknw @akka-ci @ortibazar