#22424: Use InputBuffer attribute for asynchronous inputs #22441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #22424 |
akka-ci
added
validating
|
Test FAILed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit hacky solution, because it inflates the GraphStageLogic with an extra pointer. Unfortunately there is no real nicer way to propagate the Attributes of the relevant input port to the
takePublishercall. At the point where that callback is called it is not known which stage is the corresponding input, nor what its attributes where (there is a reason whytakePublisheris the only callback that does not present thelogicfield). Tracking these would add both memory and computational overhead. If someone has a better solution don't hesitate to share.