Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename spawnAdapter due to Scala 2.12 compilation error #22595

Merged
merged 1 commit into from Mar 17, 2017
Merged

rename spawnAdapter due to Scala 2.12 compilation error #22595

merged 1 commit into from Mar 17, 2017

Conversation

patriknw
Copy link
Member

  • and make scaladoc happy ForkJoinPool.ForkJoinWorkerThreadFactory

@patriknw
rename spawnAdapter due to Scala 2.12 compilation error
d871b63 
* and make scaladoc happy ForkJoinPool.ForkJoinWorkerThreadFactory
@patriknw patriknw added this to the 2.5.0-RC1 milestone Mar 17, 2017
johanandren
johanandren reviewed Mar 17, 2017
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Mar 17, 2017
2m
2m approved these changes Mar 17, 2017
View reviewed changes
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktoso
Copy link
Member

ktoso commented Mar 17, 2017

ScalaDSL remains spawn?

@akka-ci akka-ci added the validating PR is currently being validated by Jenkins label Mar 17, 2017
@patriknw
Copy link
Member Author

Yes, must be different named. We can investigate more clever alternatives later

@ktoso
Copy link
Member

ktoso commented Mar 17, 2017 via email

@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Mar 17, 2017
@akka-ci
Copy link

akka-ci commented Mar 17, 2017

Test PASSed.

@patriknw patriknw merged commit 389dcba into master Mar 17, 2017
@2m 2m deleted the wip-spawnAdapter-2.12-patriknw branch March 17, 2017 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren left review comments

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
2.5.0-RC1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@patriknw @ktoso @akka-ci @2m @johanandren