Add customized NPE for null actor system #23580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the repo owners verify this patch? |
|
OK TO TEST |
akka-ci
added
validating
|
Test PASSed. |
ktoso
reviewed
Aug 31, 2017
| @@ -74,7 +74,9 @@ trait ExtensionId[T <: Extension] { | |||
| /** | |||
| * Returns an instance of the extension identified by this ExtensionId instance. | |||
| */ | |||
| def apply(system: ActorSystem): T = system.registerExtension(this) | |||
| def apply(system: ActorSystem): T = { | |||
| java.util.Objects.requireNonNull(system, "Null system!").registerExtension(this) | |||
|
LGTM, proposed slight rewording (can make the change if you think it's ok) |
akka-ci
added
validating
|
Test PASSed. |
raboof
approved these changes
Sep 4, 2017
|
Assigned milestone |
lucianenache
pushed a commit
to lucianenache/akka
that referenced
this pull request
Nov 6, 2017
* Add customized NPE for null actor system * "system must not be null!"
lucianenache
pushed a commit
to lucianenache/akka
that referenced
this pull request
Nov 9, 2017
* Add customized NPE for null actor system * "system must not be null!"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Add a customized NPE that indicates that the passed in actor system was null here. IllegalArgumentException would also be appropriate.
Rationale
In the HttpApp, there are various hooks that are provided for a running server:
http://doc.akka.io/docs/akka-http/current/scala/http/routing-dsl/HttpApp.html#providing-your-own-actor-system
However, the access to the actor system is controlled by systemReference, which can be null. If you try accessing
CoordinatedShutdown(systemReference.get())you'll getWhich does not indicate that a null actor system was passed in unless you look at the source code.