MultiDcSplitBrainSpec: Turn on gossip loggig; Increase gossip frequency #24024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last time this failed there was no gossip to or from a node that didn't see fifth coming back. Also note that this test doesn't quite test what it says as the split brain is repaired before starting the second actor system but without extensions to the multi jvm test kit this can't be improved. Refs akka#23306
chbatey
commented
Nov 20, 2017
| @@ -69,8 +70,8 @@ abstract class MultiDcSplitBrainSpec | |||
| val dc2 = List(third, fourth, fifth) | |||
| var barrierCounter = 0 | |||
|
|
|||
| def splitDataCenters(notMembers: Set[RoleName]): Unit = { | |||
| val memberNodes = (dc1 ++ dc2).filterNot(notMembers) | |||
| def splitDataCenters(doNotVerify: Set[RoleName]): Unit = { | |||
There was a problem hiding this comment.
Before i looked at this code i thought the nodes passed in weren't split
|
I spent quite some time re-writing this test to make it have a network partition during the start up of the second actor system on fifth but i don't think it is possible with the current multi jvm test kit |
akka-ci
added
tested
|
Test PASSed. |
johanandren
approved these changes
Nov 23, 2017
| @@ -69,8 +70,8 @@ abstract class MultiDcSplitBrainSpec | |||
| val dc2 = List(third, fourth, fifth) | |||
| var barrierCounter = 0 | |||
|
|
|||
| def splitDataCenters(notMembers: Set[RoleName]): Unit = { | |||
| val memberNodes = (dc1 ++ dc2).filterNot(notMembers) | |||
| def splitDataCenters(doNotVerify: Set[RoleName]): Unit = { | |||
Sebruck
pushed a commit
to Sebruck/akka
that referenced
this pull request
Dec 15, 2017
…cy (akka#24024) The last time this failed there was no gossip to or from a node that didn't see fifth coming back. Also note that this test doesn't quite test what it says as the split brain is repaired before starting the second actor system but without extensions to the multi jvm test kit this can't be improved. Refs akka#23306
manonthegithub
pushed a commit
to manonthegithub/akka
that referenced
this pull request
Jan 31, 2018
…cy (akka#24024) The last time this failed there was no gossip to or from a node that didn't see fifth coming back. Also note that this test doesn't quite test what it says as the split brain is repaired before starting the second actor system but without extensions to the multi jvm test kit this can't be improved. Refs akka#23306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last time this failed there was no gossip to or from a node that
didn't see fifth coming back.
Turning on gossip logging to see what is going on as well as increasing the gossip frequency.
Also note that this test doesn't quite test what it says as the split
brain is repaired before starting the second actor system but without
extensions to the multi jvm test kit this can't be improved.
Refs #23306