Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting migration guide to configure serialization of messages #24159

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

shasts
Copy link
Contributor

@shasts shasts commented Dec 14, 2017

No description provided.

@shasts
Copy link
Contributor Author

shasts commented Dec 14, 2017

Spent some time trying to figure out why my changes to turn off serialization didn't work. Turns out the key was wrong in the migration guide.

@akka-ci
Copy link

akka-ci commented Dec 14, 2017

Can one of the repo owners verify this patch?

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups. Thanks for fixing it. LGTM!

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raboof raboof merged commit e8ff22e into akka:master Dec 14, 2017
manonthegithub pushed a commit to manonthegithub/akka that referenced this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants