#24752 Fix timestamped versions #24845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Apr 4, 2018
project/AkkaBuild.scala
Outdated
| @@ -20,13 +20,15 @@ object AkkaBuild { | |||
|
|
|||
| lazy val buildSettings = Dependencies.Versions ++ Seq( | |||
| organization := "com.typesafe.akka", | |||
| version := "2.5-SNAPSHOT") | |||
| version := (version in ThisBuild).value) | |||
There was a problem hiding this comment.
could you document this a bit more? It seems rather magical where the actual value comes from now
There was a problem hiding this comment.
Okay. But with sbt inspect is the king. It shows where values for settings come from more robustly than comments.
There was a problem hiding this comment.
document intent why we do this so weirdly, and hint at inspect?
akka-ci
added
tested
|
Test PASSed. |
akka-ci
added
validating
ktoso
reviewed
Apr 5, 2018
| @@ -20,13 +20,16 @@ object AkkaBuild { | |||
|
|
|||
| lazy val buildSettings = Dependencies.Versions ++ Seq( | |||
| organization := "com.typesafe.akka", | |||
| version := "2.5-SNAPSHOT") | |||
| // use the same value as in the build scope, so it can be overriden by stampVersion | |||
akka-ci
added
tested
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we should use sbt-dynver, but currently version tagged commits are not part of the direct history of master. Upon release we fork master and add a commit which only has version change. Then we tag that commit with a release tag. Therefore sbt-dynver can not currently derive version from history.
Fixes #24752