Typed persistent event adapters/wrappers #25050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snapshot tests will fail as i made it use leveldb, before the tests relied on the sync nature of the inmemory snapshoter |
akka-ci
added
validating
|
Test FAILed. |
patriknw
reviewed
May 4, 2018
| replyProbe.expectMessage(State(1, Vector(0))) | ||
|
|
||
| val events = queries.currentEventsByPersistenceId(pid).runWith(Sink.seq).futureValue | ||
| events shouldEqual List(EventEnvelope(Sequence(1), pid, 1, Wrapper(Incremented(1)))) |
There was a problem hiding this comment.
so if one would like the unwrapped here it could be possible to use the same adapter in a map?
patriknw
reviewed
May 4, 2018
| */ | ||
| def withTagger(tagger: Event ⇒ Set[String]): PersistentBehavior[Command, Event, State] = | ||
| copy(tagger = tagger) | ||
| eventWrapper(new TaggingEventWrapper[Event](tagger)) |
There was a problem hiding this comment.
The we would have to support more than one EventWrapper and then the types would go haywire?
Perhaps keep tags separate?
There was a problem hiding this comment.
Given that journals don't return the Tagged back it doesn't fit with the Wrapper anyhow
chbatey
force-pushed
the
typed-event-wrappers
branch
from
4c46cc4
to
e646458
Compare
akka-ci
added
validating
chbatey
force-pushed
the
typed-event-wrappers
branch
from
e646458
to
2e99fc0
Compare
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
the
needs-attention
|
Test FAILed. |
akka-ci
added
validating
|
Test FAILed. |
chbatey
force-pushed
the
typed-event-wrappers
branch
from
f1f45db
to
8eb1cb7
Compare
akka-ci
added
validating
|
Test FAILed. |
|
@patriknw this is ready for a proper review now for the scaladsl. I am now just doing the javadsl but taking a little longer than expected as our java persistent actor tests haven't been running and need some attention. |
|
Test PASSed. |
johanandren
reviewed
May 14, 2018
| } else { | ||
| // Tags always need to be on the outside as journals match on it | ||
| Tagged(setup.eventAdapter.toJournal(event), tags) | ||
| } |
There was a problem hiding this comment.
Do the common logic outside of the if-else?
| * The `callback` function is called to notify the actor that the recovery process | ||
| * is finished. The default implementation logs failures at error and success writes at | ||
| * debug. | ||
| */ |
There was a problem hiding this comment.
This scaladoc documents something else?
| /** | ||
| * The `callback` function is called to notify the actor that the recovery process | ||
| * is finished. | ||
| */ |
| /** | ||
| * Transform the event in another type before giving to the journal. Can be used to wrap events | ||
| * in types Journals and Adapters understand as well as simple event migrations. | ||
| */ |
There was a problem hiding this comment.
How could it be used to do migration? If you already have the events they won't be adapted? Remove or clarify?
chbatey
changed the title
akka-ci
added
validating
|
Test PASSed. |
patriknw
added
the
2 - pick next
johanandren
approved these changes
May 24, 2018
chbatey
force-pushed
the
typed-event-wrappers
branch
from
1a3d3ff
to
429865d
Compare
|
Rebased and can be merged once validation passes |
akka-ci
added
validating
|
This also fixes #24637 |
akka-ci
added
tested
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for merge or code review.
Just wanted an opinion on a possible API that could replace the need for basic event adapters.
I called it wrapper for now as that is the current use case.