Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify typed supervision when returning a new behavior #25163

Merged
merged 1 commit into from May 31, 2018
Merged

Clarify typed supervision when returning a new behavior #25163

merged 1 commit into from May 31, 2018

Conversation

chbatey
Copy link
Member

@chbatey chbatey commented May 29, 2018

No description provided.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR is currently being validated by Jenkins labels May 29, 2018
@akka-ci
Copy link

akka-ci commented May 29, 2018

Test FAILed.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR is currently being validated by Jenkins labels May 29, 2018
@akka-ci
Copy link

akka-ci commented May 29, 2018

Test PASSed.

johanandren
johanandren approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patriknw
patriknw approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is related to #25128 but I assume that we are going to fix/prevent that issue separately. This documentation is valid independent of that issue.

...actor-typed-tests/src/test/java/jdocs/akka/typed/supervision/SupervisionCompileOnlyTest.java
}
}

public static Behavior<CounterMessage> counter(int currentValue) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add public to the message classes, since this is public and shown in docs

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR is currently being validated by Jenkins labels May 31, 2018
@akka-ci
Copy link

akka-ci commented May 31, 2018

Test PASSed.

@chbatey chbatey added this to the 2.5.14 milestone May 31, 2018
@chbatey chbatey merged commit c8f4a17 into akka:master May 31, 2018
@chbatey chbatey mentioned this pull request Jun 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
2.5.14
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chbatey @akka-ci @patriknw @johanandren