Typed: Un-nest supervision that overlaps #25269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Jun 25, 2018
| ).onFailure[RuntimeException](SupervisorStrategy.restartWithLimit(23, 10.seconds)) | ||
| ).onFailure[IllegalArgumentException](SupervisorStrategy.restart) | ||
| ).onFailure[RuntimeException](SupervisorStrategy.restart) | ||
| }).onFailure[RuntimeException](SupervisorStrategy.stop) |
There was a problem hiding this comment.
"hadouken!"
// totally fine to keep it, just reminded me of the old pic... ;-)
There was a problem hiding this comment.
Pyramid of supervision doom!
ktoso
reviewed
Jun 25, 2018
| } | ||
|
|
||
| override def toString = s"restartWithLimit(${strategy.maxNrOfRetries}, ${strategy.withinTimeRange}" |
There was a problem hiding this comment.
nice to strings in general though
akka-ci
added
tested
|
Test PASSed. |
akka-ci
added
validating
patriknw
approved these changes
Jun 25, 2018
| behavior match { | ||
| case s: Supervisor[T, _] ⇒ | ||
| val inner = loop(s.behavior) | ||
| if (seenSupervised.contains(s.throwableClass)) |
There was a problem hiding this comment.
we could discard subclasses also but makes it a bit more complicated and the main purpose is to remove the accidental wrapping of same
There was a problem hiding this comment.
Yeah, I thought about that, but wasn't sure it is worth because it isn't very realistic that you add more general and more general supervision over time.
| inner | ||
| else { | ||
| seenSupervised += s.throwableClass | ||
| if (inner.eq(s.behavior)) s |
| } | ||
|
|
||
| override def toString = s"restartWithBackoff(${strategy.minBackoff}, ${strategy.maxBackoff}, ${strategy.randomFactor})" |
akka-ci
added
validating
|
Test PASSed. |
|
Test PASSed. |
akka-ci
added
validating
|
Test PASSed. |
johanandren
deleted the
wip-25128-nested-supervision-akka-typed-johanandren
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25128
Also snuck in logging of the used strategy on failure in the supervision logs.