New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes compile warning introduced in #25987 #26244
Conversation
Test PASSed. |
@helena Heres the fixed compile warning. |
@@ -127,6 +127,9 @@ private[io] final class AsyncDnsResolver( | |||
if (resolved.records.isEmpty) resolveFirst(remaining, requestType, resolver) | |||
else Future.successful(resolved) | |||
} | |||
case Nil ⇒ | |||
// This can't happen | |||
sys.error("resolveFirst shouldn't be called with empty searchNames") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer throw IllegalStateException
since may go noticed
Thanks @jroper ! Looks like just a minor change in response to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change for Nil
Sorry @helena, this slipped through the cracks. Thanks for following up. |
Fixes #26239