Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends collection of shutdown Reasons (e.g. ClusterJoinUnsuccessfulReason) #26570

Conversation

Projects
None yet
4 participants
@ignasi35
Copy link
Member

commented Mar 19, 2019

Related to lagom/lagom#1806

/**
* Scala API: The shutdown was initiated by a failure to join a seed node.
*/
object JoiningSeedNodesUnsuccessfulReason extends Reason

This comment has been minimized.

Copy link
@johanandren

johanandren Mar 19, 2019

Member

That seems extremely specific, should it rather be ClusterJoinUnsuccessful or something like that, or is it important that it was specifically joining to seed nodes that failed?

This comment has been minimized.

Copy link
@patriknw

patriknw Mar 19, 2019

Member

I agree, could be slightly less specific

This comment has been minimized.

Copy link
@ignasi35

ignasi35 Mar 20, 2019

Author Member

SGTM

/**
* Java API: The shutdown was initiated by a configuration clash within the existing cluster and the joining node
*/
def incompatibleConfigurationDetectedReason: Reason = IncompatibleConfigurationDetectedReason

This comment has been minimized.

Copy link
@johanandren

johanandren Mar 19, 2019

Member

Sounds like it makes sense to make it public

@akka-ci akka-ci added needs-attention and removed validating labels Mar 19, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

Test FAILed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

Test FAILed.

@patriknw
Copy link
Member

left a comment

seems good to add those

@ignasi35 ignasi35 changed the title Adds JoiningSeedNodesUnsuccessfulReason Extends collection of shutdown Reasons (e.g. ClusterJoinUnsuccessfulReason) Mar 20, 2019

@@ -501,7 +501,7 @@ private[cluster] class ClusterCoreDaemon(publisher: ActorRef, joinConfigCompatCh
seedNodes.mkString(", "),
ShutdownAfterUnsuccessfulJoinSeedNodes)
joinSeedNodesDeadline = None
CoordinatedShutdown(context.system).run(CoordinatedShutdown.ClusterDowningReason)
CoordinatedShutdown(context.system).run(CoordinatedShutdown.ClusterJoinUnsuccessfulReason)

This comment has been minimized.

Copy link
@patriknw

patriknw Mar 20, 2019

Member

Currently we have ClusterDowningReason configured to use exit code -1 (abnormal termination). Shouldn't ClusterJoinUnsuccessfulReason also be configured to use -1.

I guess -1 will have the effect that an orchestration platform will start it again, which is probably desired also for unsuccessful join?

This comment has been minimized.

Copy link
@ignasi35

ignasi35 Mar 20, 2019

Author Member

Hmmm, I think the exit status was relevant in ConductR but I don't think it is in Kubernetes. IDK about other orchestrators.

I'll fix this PR but I think we could consider deprecating the feature.

This comment has been minimized.

Copy link
@patriknw

patriknw Mar 20, 2019

Member

The exit code is useful. k8 isn't the only thing. A bash script can check exit code for decision of restarting process.

This comment has been minimized.

Copy link
@ignasi35

ignasi35 Mar 20, 2019

Author Member

Hmmm, in the case of IncompatibleConfigurationDetectedReason restarting won't help so I don't think a custom exit code is necessary.

This comment has been minimized.

Copy link
@patriknw

patriknw Mar 20, 2019

Member

I agree, IncompatibleConfigurationDetectedReason

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Mar 20, 2019

Test FAILed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Mar 20, 2019

Test FAILed.

@akka-ci akka-ci added the validating label Mar 21, 2019

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Mar 21, 2019

Test FAILed.

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Mar 21, 2019

Test PASSed.

@ignasi35

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2019

The Travis job failed this morning but I think the cause was a failing bintray. Can someone relaunch, please?

@johanandren

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

PLS BUILD

@akka-ci

This comment has been minimized.

Copy link
Collaborator

commented Mar 21, 2019

Test PASSed.

@patriknw
Copy link
Member

left a comment

LGTM

@patriknw patriknw merged commit c097e81 into akka:master Mar 26, 2019

3 checks passed

Jenkins PR Validation Test PASSed. 2637 tests run, 18 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
typesafe-cla-validator All users have signed the CLA
Details

@patriknw patriknw added this to the 2.5.22 milestone Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.