Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove akka-contrib #26769

Merged
merged 2 commits into from May 2, 2019
Merged

Remove akka-contrib #26769

merged 2 commits into from May 2, 2019

Conversation

raboof
Copy link
Member

@raboof raboof commented Apr 17, 2019

Refs #26183

This module has been deprecated since 2.5 and is removed in 2.6

@akka-ci akka-ci added the validating PR is currently being validated by Jenkins label Apr 17, 2019
patriknw
patriknw reviewed Apr 17, 2019
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start a migration guide 2.5 -> 2.6 page also and mention the removals there. Here is not much migration guidance other than the source can be copied if someone is depending on it.

@akka-ci akka-ci added tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Apr 17, 2019
@akka-ci
Copy link

akka-ci commented Apr 17, 2019

Test PASSed.

patriknw
patriknw reviewed Apr 24, 2019
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention in migration guide, replacement would be to copy used sources from 2.5

@raboof raboof force-pushed the removeAkkaContrib branch 2 times, most recently from 8145f28 to e914569 Compare April 24, 2019 12:32
@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR is currently being validated by Jenkins labels Apr 24, 2019
@akka-ci
Copy link

akka-ci commented Apr 24, 2019

Test PASSed.

1 similar comment
@akka-ci
Copy link

akka-ci commented Apr 24, 2019

Test PASSed.

chbatey
chbatey reviewed Apr 25, 2019
View reviewed changes
Copy link
Member

@chbatey chbatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

patriknw
patriknw approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but has conflict in migration guide now

akka-docs/src/main/paradox/project/migration-guide-2.5.x-2.6.x.md
@@ -1,5 +1,11 @@
# Migration Guide 2.5.x to 2.6.x

## Removed module: akka-contrib

The akka-contrib module was deprecated in 2.5 and has been removed in 2.6.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.5.0

@patriknw patriknw added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label May 2, 2019
@patriknw
Copy link
Member

patriknw commented May 2, 2019

rebase and merge

raboof added 2 commits May 2, 2019 10:10
@raboof
Remove akka-contrib #26183
ea0b016 
This module has been deprecated since 2.5 and is removed in 2.6
@raboof
Migration guide
7a10763
@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR is currently being validated by Jenkins labels May 2, 2019
@akka-ci
Copy link

akka-ci commented May 2, 2019

Test PASSed.

@raboof raboof merged commit 282b38e into master May 2, 2019
@raboof raboof deleted the removeAkkaContrib branch May 2, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

@chbatey chbatey chbatey approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raboof @akka-ci @patriknw @chbatey