Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stashing of commands when snapshot is in progress #27389

Merged
merged 2 commits into from Jul 25, 2019
Merged

Fix stashing of commands when snapshot is in progress #27389

merged 2 commits into from Jul 25, 2019

Conversation

chbatey
Copy link
Member

@chbatey chbatey commented Jul 22, 2019

Fixes #27381

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Jul 22, 2019
@akka-ci
Copy link

akka-ci commented Jul 22, 2019

Test PASSed.

helena
helena reviewed Jul 23, 2019
View reviewed changes
akka-persistence-typed/src/test/scala/akka/persistence/typed/StashingWhenSnapshottingSpec.scala Outdated
}
""")

def pa(pid: PersistenceId, eventProbe: TestProbe[String]) =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a more descriptive function name.

helena
helena reviewed Jul 23, 2019
View reviewed changes
akka-persistence-typed/src/test/scala/akka/persistence/typed/StashingWhenSnapshottingSpec.scala
ControllableSnapshotStoreExt(system).completeSnapshotWrite.complete(Success(()))
eventProbe.expectMessage("two")
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any failure to test here as well?

@chbatey chbatey added the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Jul 24, 2019
jrudolph
jrudolph approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raboof
raboof approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have this in - perhaps look at that method name before merging?

@raboof
Copy link
Member

raboof commented Jul 25, 2019

(i'll amend with a quick rename and then merge)

@chbatey
Copy link
Member Author

chbatey commented Jul 25, 2019

Thanks @raboof

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR is currently being validated by Jenkins labels Jul 25, 2019
@akka-ci
Copy link

akka-ci commented Jul 25, 2019

Test PASSed.

@raboof raboof merged commit 4f6cccc into akka:master Jul 25, 2019
@raboof raboof added this to the 2.6.0-M5 milestone Jul 25, 2019
raboof pushed a commit that referenced this pull request Jul 25, 2019
@chbatey @raboof
Fix stashing of commands when snapshot is in progress (#27389)
15ba6af 
* Fix stashing of commands when snapshot is in progress

Fixes #27381

* Naming
raboof added a commit that referenced this pull request Jul 25, 2019
@raboof
Fix stashing of commands when snapshot is in progress (#27389) (#27415)
57e9982 
* Fix stashing of commands when snapshot is in progress

Fixes #27381

* Naming
@chbatey chbatey deleted the issue-27381 branch July 26, 2019 08:34
patriknw
patriknw reviewed Aug 13, 2019
View reviewed changes
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/Running.scala
@@ -338,7 +338,7 @@ private[akka] object Running {
setup.log.debug("Discarding message [{}], because actor is to be stopped.", cmd)
Behaviors.unhandled
} else {
stashUser(cmd)
stashInternal(cmd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch :)

johanandren pushed a commit to johanandren/akka that referenced this pull request Aug 28, 2019
@chbatey @johanandren
Fix stashing of commands when snapshot is in progress (akka#27389)
693baef 
* Fix stashing of commands when snapshot is in progress

Fixes akka#27381

* Naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw left review comments

@helena helena helena left review comments

@jrudolph jrudolph jrudolph approved these changes

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding tested PR that was successfully built and tested by Jenkins to-be-backported
Projects
None yet
Milestone
2.6.0-M5
Development

Successfully merging this pull request may close these issues.

akka-persistence-typed is loosing commands received while snapshots are created
6 participants
@chbatey @akka-ci @raboof @jrudolph @patriknw @helena