Dotty syntax compat

.scalafix.conf

@@ -1,7 +1,14 @@
 // .scalafix.conf
 rules = [
   RemoveUnused
+//  ExplicitResultTypes
+//  "github:ohze/scalafix-rules/ConstructorProcedureSyntax"
+//  "github:ohze/scalafix-rules/FinalObject"
 ]
+ExplicitResultTypes {
+  memberVisibility = [] # only rewrite implicit members
+  skipSimpleDefinitions = []
+}
 RemoveUnused.imports = true
 RemoveUnused.privates = false
 RemoveUnused.locals = false

akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/CapturedLogEvent.scala

@@ -28,37 +28,32 @@ final case class CapturedLogEvent(level: Level, message: String, cause: Option[T
       message: String,
       errorCause: Optional[Throwable],
       marker: Optional[Marker],
-      mdc: java.util.Map[String, Any]) {
+      mdc: java.util.Map[String, Any]) =
     this(level, message, errorCause.asScala, marker.asScala)
-  }
 
   /**
    * Constructor for Java API
    */
-  def this(level: Level, message: String) {
+  def this(level: Level, message: String) =
     this(level, message, Option.empty, Option.empty)
-  }
 
   /**
    * Constructor for Java API
    */
-  def this(level: Level, message: String, errorCause: Throwable) {
+  def this(level: Level, message: String, errorCause: Throwable) =
     this(level, message, Some(errorCause), Option.empty[Marker])
-  }
 
   /**
    * Constructor for Java API
    */
-  def this(level: Level, message: String, marker: Marker) {
+  def this(level: Level, message: String, marker: Marker) =
     this(level, message, Option.empty[Throwable], Some(marker))
-  }
 
   /**
    * Constructor for Java API
    */
-  def this(level: Level, message: String, errorCause: Throwable, marker: Marker) {
+  def this(level: Level, message: String, errorCause: Throwable, marker: Marker) =
     this(level, message, Some(errorCause), Some(marker))
-  }
 
   def getErrorCause: Optional[Throwable] = cause.asJava
 

akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/Effect.scala

@@ -191,7 +191,7 @@ object Effect {
     def duration(): java.time.Duration = d.asJava
   }
 
-  final case object ReceiveTimeoutCancelled extends ReceiveTimeoutCancelled
+  case object ReceiveTimeoutCancelled extends ReceiveTimeoutCancelled
 
   sealed abstract class ReceiveTimeoutCancelled extends Effect
 

akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/TestKitSettings.scala

@@ -43,7 +43,7 @@ object TestKitSettings {
 
   private object Ext extends ExtensionId[Ext] {
     override def createExtension(system: ActorSystem[_]): Ext = new Ext(system)
-    def get(system: ActorSystem[_]): Ext = apply(system)
+    def get(system: ActorSystem[_]): Ext = this.apply(system)
   }
 
   private class Ext(system: ActorSystem[_]) extends Extension {

akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/internal/BehaviorTestKitImpl.scala

@@ -28,7 +28,8 @@ private[akka] final class BehaviorTestKitImpl[T](_path: ActorPath, _initialBehav
     with akka.actor.testkit.typed.scaladsl.BehaviorTestKit[T] {
 
   // really this should be private, make so when we port out tests that need it
-  private[akka] val context = new EffectfulActorContext[T](_path, () => currentBehavior)
+  // need explicitly declaring type here because lampepfl/dotty#8675
+  private[akka] val context: EffectfulActorContext[T] = new EffectfulActorContext[T](_path, () => currentBehavior)
 
   private[akka] def as[U]: BehaviorTestKitImpl[U] = this.asInstanceOf[BehaviorTestKitImpl[U]]
 
@@ -128,7 +129,7 @@ private[akka] final class BehaviorTestKitImpl[T](_path: ActorPath, _initialBehav
     } catch handleException
   }
 
-  override def runOne(): Unit = run(selfInbox.receiveMessage())
+  override def runOne(): Unit = run(selfInbox().receiveMessage())
 
   override def signal(signal: Signal): Unit = {
     try {

akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/internal/StubbedActorContext.scala

@@ -147,7 +147,7 @@ private[akka] final class FunctionRef[-T](override val path: ActorPath, send: (T
     new FunctionRef[U](p, (message, _) => {
       val m = f(message);
       if (m != null) {
-        selfInbox.ref ! m; i.selfInbox.ref ! message
+        selfInbox.ref ! m; i.selfInbox().ref ! message
       }
     })
   }

akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/internal/TestKitUtils.scala

@@ -30,7 +30,7 @@ private[akka] object ActorTestKitGuardian {
   final case class StopActor[T](ref: ActorRef[T], replyTo: ActorRef[Ack.type]) extends TestKitCommand
   final case class ActorStopped[T](replyTo: ActorRef[Ack.type]) extends TestKitCommand
 
-  final case object Ack
+  case object Ack
 
   val testKitGuardian: Behavior[TestKitCommand] = Behaviors.receive[TestKitCommand] {
     case (context, SpawnActor(name, behavior, reply, props)) =>

akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/javadsl/BehaviorTestKit.scala

@@ -75,7 +75,7 @@ abstract class BehaviorTestKit[T] {
   /**
    * The self reference of the actor living inside this testkit.
    */
-  def getRef(): ActorRef[T] = selfInbox.getRef()
+  def getRef(): ActorRef[T] = selfInbox().getRef()
 
   /**
    * Requests all the effects. The effects are consumed, subsequent calls will only

akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/scaladsl/ActorTestKit.scala

@@ -244,7 +244,7 @@ final class ActorTestKit private[akka] (
    */
   def stop[T](ref: ActorRef[T], max: FiniteDuration = timeout.duration): Unit =
     try {
-      Await.result(internalTestKitGuardian.ask { x: ActorRef[ActorTestKitGuardian.Ack.type] =>
+      Await.result(internalTestKitGuardian.ask { (x: ActorRef[ActorTestKitGuardian.Ack.type]) =>
         ActorTestKitGuardian.StopActor(ref, x)
       }, max)
     } catch {

akka-actor-testkit-typed/src/main/scala/akka/actor/testkit/typed/scaladsl/BehaviorTestKit.scala

@@ -72,7 +72,7 @@ trait BehaviorTestKit[T] {
   /**
    * The self reference of the actor living inside this testkit.
    */
-  def ref: ActorRef[T] = selfInbox.ref
+  def ref: ActorRef[T] = selfInbox().ref
 
   /**
    * Requests all the effects. The effects are consumed, subsequent calls will only

akka-actor-testkit-typed/src/test/scala/akka/actor/testkit/typed/scaladsl/BehaviorTestKitSpec.scala

@@ -69,12 +69,12 @@ object BehaviorTestKitSpec {
           context.stop(child)
           Behaviors.same
         case SpawnAdapter =>
-          context.spawnMessageAdapter { r: Reproduce =>
+          context.spawnMessageAdapter { (r: Reproduce) =>
             SpawnAnonymous(r.times)
           }
           Behaviors.same
         case SpawnAdapterWithName(name) =>
-          context.spawnMessageAdapter({ r: Reproduce =>
+          context.spawnMessageAdapter({ (r: Reproduce) =>
             SpawnAnonymous(r.times)
           }, name)
           Behaviors.same
@@ -310,7 +310,7 @@ class BehaviorTestKitSpec extends AnyWordSpec with Matchers with LogCapturing {
       val d = TestInbox[Done]()
       testkit.run(KillSession(sessionRef, d.ref))
 
-      d.receiveAll shouldBe Seq(Done)
+      d.receiveAll() shouldBe Seq(Done)
       testkit.expectEffectType[Stopped]
     }
 

akka-actor-testkit-typed/src/test/scala/akka/actor/testkit/typed/scaladsl/TestProbeSpec.scala

@@ -148,7 +148,7 @@ class TestProbeSpec extends ScalaTestWithActorTestKit with AnyWordSpecLike with
       val probe = createTestProbe[EventT]()
       eventsT(10).forall { e =>
         probe.ref ! e
-        probe.receiveMessage == e
+        probe.receiveMessage() == e
       } should ===(true)
 
       probe.expectNoMessage()

akka-actor-tests/src/test/scala/akka/actor/ActorConfigurationVerificationSpec.scala

@@ -40,7 +40,7 @@ class ActorConfigurationVerificationSpec
     with BeforeAndAfterEach {
   import ActorConfigurationVerificationSpec._
 
-  override def atStartup: Unit = {
+  override def atStartup(): Unit = {
     system.eventStream.publish(Mute(EventFilter[ConfigurationException]("")))
   }
 

akka-actor-tests/src/test/scala/akka/actor/ActorLifeCycleSpec.scala

@@ -117,7 +117,7 @@ class ActorLifeCycleSpec extends AkkaSpec with BeforeAndAfterEach with ImplicitS
     "log failures in postStop" in {
       val a = system.actorOf(Props(new Actor {
         def receive = Actor.emptyBehavior
-        override def postStop: Unit = { throw new Exception("hurrah") }
+        override def postStop(): Unit = { throw new Exception("hurrah") }
       }))
       EventFilter[Exception]("hurrah", occurrences = 1).intercept {
         a ! PoisonPill

akka-actor-tests/src/test/scala/akka/actor/ActorRefSpec.scala

@@ -391,7 +391,7 @@ class ActorRefSpec extends AkkaSpec("""
 
       Await.ready(latch, timeout.duration)
 
-      latch.reset
+      latch.reset()
 
       clientRef ! "complex2"
       clientRef ! "simple"

akka-actor-tests/src/test/scala/akka/actor/ActorSelectionSpec.scala

@@ -355,7 +355,7 @@ class ActorSelectionSpec extends AkkaSpec with DefaultTimeout {
 
     "identify actors with wildcard selection correctly" in {
       val creator = TestProbe()
-      implicit def self = creator.ref
+      implicit def self: ActorRef = creator.ref
       val top = system.actorOf(p, "a")
       val b1 = Await.result((top ? Create("b1")).mapTo[ActorRef], timeout.duration)
       val b2 = Await.result((top ? Create("b2")).mapTo[ActorRef], timeout.duration)

akka-actor-tests/src/test/scala/akka/actor/ActorSystemSpec.scala

@@ -78,11 +78,11 @@ object ActorSystemSpec {
       extends MessageDispatcherConfigurator(_config, _prerequisites) {
     private val instance = new Dispatcher(
       this,
-      config.getString("id"),
-      config.getInt("throughput"),
-      config.getNanosDuration("throughput-deadline-time"),
+      this.config.getString("id"),
+      this.config.getInt("throughput"),
+      this.config.getNanosDuration("throughput-deadline-time"),
       configureExecutor(),
-      config.getMillisDuration("shutdown-timeout")) {
+      this.config.getMillisDuration("shutdown-timeout")) {
       val doneIt = new Switch
       override protected[akka] def registerForExecution(
           mbox: Mailbox,
@@ -263,7 +263,7 @@ class ActorSystemSpec extends AkkaSpec(ActorSystemSpec.config) with ImplicitSend
 
     "reliably create waves of actors" in {
       import system.dispatcher
-      implicit val timeout = Timeout((20 seconds).dilated)
+      implicit val timeout: Timeout = Timeout((20 seconds).dilated)
       val waves = for (_ <- 1 to 3) yield system.actorOf(Props[ActorSystemSpec.Waves]) ? 50000
       Await.result(Future.sequence(waves), timeout.duration + 5.seconds) should ===(Vector("done", "done", "done"))
     }

akka-actor-tests/src/test/scala/akka/actor/ActorWithBoundedStashSpec.scala

@@ -92,7 +92,7 @@ class ActorWithBoundedStashSpec
     with ImplicitSender {
   import ActorWithBoundedStashSpec._
 
-  override def atStartup: Unit = {
+  override def atStartup(): Unit = {
     system.eventStream.publish(Mute(EventFilter.warning(pattern = ".*received dead letter from.*hello.*")))
   }
 

akka-actor-tests/src/test/scala/akka/actor/ActorWithStashSpec.scala

@@ -24,7 +24,7 @@ object ActorWithStashSpec {
     def greeted: Receive = {
       case "bye" =>
         state.s = "bye"
-        state.finished.await
+        state.finished.await()
       case _ => // do nothing
     }
 
@@ -63,7 +63,7 @@ object ActorWithStashSpec {
             context.unbecome()
           case _ => stash()
         }
-      case "done" => state.finished.await
+      case "done" => state.finished.await()
       case _      => stash()
     }
   }
@@ -105,19 +105,19 @@ class JavaActorWithStashSpec extends StashJavaAPI with JUnitSuiteLike
 class ActorWithStashSpec extends AkkaSpec with DefaultTimeout with BeforeAndAfterEach {
   import ActorWithStashSpec._
 
-  override def atStartup: Unit = {
+  override def atStartup(): Unit = {
     system.eventStream.publish(Mute(EventFilter[Exception]("Crashing...")))
   }
 
-  override def beforeEach() = state.finished.reset
+  override def beforeEach() = state.finished.reset()
 
   "An Actor with Stash" must {
 
     "stash messages" in {
       val stasher = system.actorOf(Props(new StashingActor))
       stasher ! "bye"
       stasher ! "hello"
-      state.finished.await
+      state.finished.await()
       state.s should ===("bye")
     }
 
@@ -130,7 +130,7 @@ class ActorWithStashSpec extends AkkaSpec with DefaultTimeout with BeforeAndAfte
       protoActor ! "write"
       protoActor ! "close"
       protoActor ! "done"
-      state.finished.await
+      state.finished.await()
     }
 
     "throw an IllegalStateException if the same messages is stashed twice" in {

akka-actor-tests/src/test/scala/akka/actor/DeathWatchSpec.scala

@@ -44,7 +44,7 @@ object DeathWatchSpec {
         context.become {
           case Terminated(`currentKid`) =>
             testActor ! "GREEN"
-            context unbecome
+            context.unbecome()
         }
     }
   }
@@ -83,7 +83,7 @@ trait DeathWatchSpec { this: AkkaSpec with ImplicitSender with DefaultTimeout =>
 
   "The Death Watch" must {
     def expectTerminationOf(actorRef: ActorRef) =
-      expectMsgPF(5 seconds, actorRef + ": Stopped or Already terminated when linking") {
+      expectMsgPF(5 seconds, actorRef.toString + ": Stopped or Already terminated when linking") {
         case WrappedTerminated(Terminated(`actorRef`)) => true
       }
 
@@ -210,19 +210,19 @@ trait DeathWatchSpec { this: AkkaSpec with ImplicitSender with DefaultTimeout =>
     }
 
     "only notify when watching" in {
-      val subject = system.actorOf(Props[EmptyActor]())
+      val subject = system.actorOf(Props[EmptyActor])
 
       testActor
         .asInstanceOf[InternalActorRef]
         .sendSystemMessage(DeathWatchNotification(subject, existenceConfirmed = true, addressTerminated = false))
 
       // the testActor is not watching subject and will not receive a Terminated msg
-      expectNoMessage
+      expectNoMessage()
     }
 
     "discard Terminated when unwatched between sysmsg and processing" in {
       val t1, t2 = TestLatch()
-      val w = system.actorOf(Props[WUWatcher]().withDeploy(Deploy.local), "myDearWatcher")
+      val w = system.actorOf(Props[WUWatcher].withDeploy(Deploy.local), "myDearWatcher")
       val p = TestProbe()
       w ! W(p.ref)
       w ! Latches(t1, t2)

akka-actor-tests/src/test/scala/akka/actor/ExtensionSpec.scala

@@ -19,15 +19,15 @@ import org.scalatestplus.junit.JUnitSuiteLike
 class JavaExtensionSpec extends JavaExtension with JUnitSuiteLike
 
 object TestExtension extends ExtensionId[TestExtension] with ExtensionIdProvider {
-  def lookup = this
+  def lookup() = this
   def createExtension(s: ExtendedActorSystem) = new TestExtension(s)
 }
 
 // Dont't place inside ActorSystemSpec object, since it will not be garbage collected and reference to system remains
 class TestExtension(val system: ExtendedActorSystem) extends Extension
 
 object FailingTestExtension extends ExtensionId[FailingTestExtension] with ExtensionIdProvider {
-  def lookup = this
+  def lookup() = this
   def createExtension(s: ExtendedActorSystem) = new FailingTestExtension(s)
 
   class TestException extends IllegalArgumentException("ERR") with NoStackTrace