[WIP] Cross-compile Akka with Scala 3

.gitignore

@@ -17,6 +17,7 @@
 .*.swp
 .DS_Store
 .bloop/
+.bsp/
 .cache
 .classpath
 .codefellow

akka-actor-tests/src/test/java/akka/pattern/StatusReplyTest.java

@@ -4,7 +4,7 @@
 
 package akka.pattern;
 
-import akka.actor.Actor;
+import akka.actor.ActorRef;
 import akka.testkit.AkkaJUnitActorSystemResource;
 import akka.testkit.AkkaSpec;
 import akka.testkit.TestException;
@@ -81,7 +81,7 @@ public void testAskWithStatusSuccess() throws Exception {
 
     CompletionStage<Object> response = askWithStatus(probe.ref(), "request", Duration.ofSeconds(3));
     probe.expectMsg("request");
-    probe.lastSender().tell(StatusReply.success("woho"), Actor.noSender());
+    probe.lastSender().tell(StatusReply.success("woho"), ActorRef.noSender());
 
     Object result = response.toCompletableFuture().get(3, TimeUnit.SECONDS);
     assertEquals("woho", result);
@@ -93,7 +93,7 @@ public void testAskWithStatusErrorMessage() throws Exception {
 
     CompletionStage<Object> response = askWithStatus(probe.ref(), "request", Duration.ofSeconds(3));
     probe.expectMsg("request");
-    probe.lastSender().tell(StatusReply.error("boho"), Actor.noSender());
+    probe.lastSender().tell(StatusReply.error("boho"), ActorRef.noSender());
 
     try {
       Object result = response.toCompletableFuture().get(3, TimeUnit.SECONDS);
@@ -110,7 +110,7 @@ public void testAskWithStatusErrorException() throws Exception {
 
     CompletionStage<Object> response = askWithStatus(probe.ref(), "request", Duration.ofSeconds(3));
     probe.expectMsg("request");
-    probe.lastSender().tell(StatusReply.error(new TestException("boho")), Actor.noSender());
+    probe.lastSender().tell(StatusReply.error(new TestException("boho")), ActorRef.noSender());
 
     try {
       Object result = response.toCompletableFuture().get(3, TimeUnit.SECONDS);

akka-actor-tests/src/test/scala/akka/AkkaExceptionSpec.scala

@@ -16,6 +16,9 @@ import akka.actor._
  */
 class AkkaExceptionSpec extends AnyWordSpec with Matchers {
 
+  // TODO DOTTY, yes I know it's wrong
+  implicit val pos: org.scalactic.source.Position = new org.scalactic.source.Position(fileName = "", filePathname = "", lineNumber = 1)
+
   "AkkaException" must {
     "have a AkkaException(String msg) constructor to be serialization friendly" in {
       //if the call to this method completes, we know what there is at least a single constructor which has

akka-actor-tests/src/test/scala/akka/AkkaVersionSpec.scala

@@ -9,6 +9,9 @@ import org.scalatest.wordspec.AnyWordSpec
 
 class AkkaVersionSpec extends AnyWordSpec with Matchers {
 
+  // TODO DOTTY, yes I know it's wrong
+  implicit val pos: org.scalactic.source.Position = new org.scalactic.source.Position(fileName = "", filePathname = "", lineNumber = 1)
+
   "The Akka version check" must {
 
     "succeed if version is ok" in {

akka-actor-tests/src/test/scala/akka/actor/ActorConfigurationVerificationSpec.scala

@@ -41,6 +41,9 @@ class ActorConfigurationVerificationSpec
     with BeforeAndAfterEach {
   import ActorConfigurationVerificationSpec._
 
+    // TODO DOTTY
+  protected override def runTest(testName: String, args: org.scalatest.Args): org.scalatest.Status = akka.testkit.ScalatestRunTest.scalatestRunTest(testName, args)
+
   override def atStartup(): Unit = {
     system.eventStream.publish(Mute(EventFilter[ConfigurationException]("")))
   }

akka-actor-tests/src/test/scala/akka/actor/ActorLifeCycleSpec.scala

@@ -30,6 +30,9 @@ object ActorLifeCycleSpec {
 class ActorLifeCycleSpec extends AkkaSpec with BeforeAndAfterEach with ImplicitSender with DefaultTimeout {
   import ActorLifeCycleSpec._
 
+  // TODO DOTTY
+  protected override def runTest(testName: String, args: org.scalatest.Args): org.scalatest.Status = akka.testkit.ScalatestRunTest.scalatestRunTest(testName, args)
+
   "An Actor" must {
 
     "invoke preRestart, preStart, postRestart when using OneForOneStrategy" in {

akka-actor-tests/src/test/scala/akka/actor/ActorMailboxSpec.scala

@@ -236,7 +236,12 @@ class ActorMailboxSpec(conf: Config) extends AkkaSpec(conf) with DefaultTimeout
 
     actor ! "ping"
     val q = expectMsgType[MessageQueue]
-    types.foreach(t => assert(t.isInstance(q), s"Type [${q.getClass.getName}] is not assignable to [${t.getName}]"))
+    // TODO DOTTY
+    import scala.language.postfixOps
+    types.foreach(t =>
+      // require(t.isInstance(q), s"Type [${q.getClass.getName}] is not assignable to [${t.getName}]")
+      t.isInstance(q).shouldBe(true)
+    )
     q
   }
 

akka-actor-tests/src/test/scala/akka/actor/ActorPathSpec.scala

@@ -11,6 +11,9 @@ import org.scalatest.wordspec.AnyWordSpec
 
 class ActorPathSpec extends AnyWordSpec with Matchers {
 
+  // TODO DOTTY, yes I know it's wrong
+  implicit val pos: org.scalactic.source.Position = new org.scalactic.source.Position(fileName = "", filePathname = "", lineNumber = 1)
+
   "An ActorPath" must {
 
     "support parsing its String rep" in {
@@ -59,9 +62,10 @@ class ActorPathSpec extends AnyWordSpec with Matchers {
 
     "create correct toStringWithAddress" in {
       val local = Address("akka", "mysys")
-      val a = local.copy(host = Some("aaa"), port = Some(2552))
-      val b = a.copy(host = Some("bb"))
-      val c = a.copy(host = Some("cccc"))
+      // TODO DOTTY
+      val a = Address("akka", "mysys", host = "aaa", port = 2552)
+      val b = Address("akka", "mysys", host = "bb", port = 2552)
+      val c = Address("akka", "mysys", host = "cccc", port = 2552)
       val root = RootActorPath(local)
       root.toStringWithAddress(a) should ===("akka://mysys@aaa:2552/")
       (root / "user").toStringWithAddress(a) should ===("akka://mysys@aaa:2552/user")
@@ -92,31 +96,31 @@ class ActorPathSpec extends AnyWordSpec with Matchers {
 
     "detect valid and invalid chars in host names when not using AddressFromURIString, e.g. docker host given name" in {
       Seq(
-        Address("akka", "sys", Some("valid"), Some(0)),
-        Address("akka", "sys", Some("is_valid.org"), Some(0)),
-        Address("akka", "sys", Some("fu.is_valid.org"), Some(0))).forall(_.hasInvalidHostCharacters) shouldBe false
+        Address("akka", "sys", "valid", 0),
+        Address("akka", "sys", "is_valid.org", 0),
+        Address("akka", "sys", "fu.is_valid.org", 0)).forall(_.hasInvalidHostCharacters) shouldBe false
 
-      Seq(Address("akka", "sys", Some("in_valid"), Some(0)), Address("akka", "sys", Some("invalid._org"), Some(0)))
+      Seq(Address("akka", "sys", "in_valid", 0), Address("akka", "sys", "invalid._org", 0))
         .forall(_.hasInvalidHostCharacters) shouldBe true
 
       intercept[MalformedURLException](AddressFromURIString("akka://sys@in_valid:5001"))
     }
 
     "not fail fast if the check is called on valid chars in host names" in {
       Seq(
-        Address("akka", "sys", Some("localhost"), Some(0)),
-        Address("akka", "sys", Some("is_valid.org"), Some(0)),
-        Address("akka", "sys", Some("fu.is_valid.org"), Some(0))).foreach(_.checkHostCharacters())
+        Address("akka", "sys", "localhost", 0),
+        Address("akka", "sys", "is_valid.org", 0),
+        Address("akka", "sys", "fu.is_valid.org", 0)).foreach(_.checkHostCharacters())
     }
 
     "fail fast if the check is called when invalid chars are in host names" in {
       Seq(
-        Address("akka", "sys", Some("localhost"), Some(0)),
-        Address("akka", "sys", Some("is_valid.org"), Some(0)),
-        Address("akka", "sys", Some("fu.is_valid.org"), Some(0))).foreach(_.checkHostCharacters())
+        Address("akka", "sys", "localhost", 0),
+        Address("akka", "sys", "is_valid.org", 0),
+        Address("akka", "sys", "fu.is_valid.org", 0)).foreach(_.checkHostCharacters())
 
-      intercept[IllegalArgumentException](Address("akka", "sys", Some("in_valid"), Some(0)).checkHostCharacters())
-      intercept[IllegalArgumentException](Address("akka", "sys", Some("invalid._org"), Some(0)).checkHostCharacters())
+      intercept[IllegalArgumentException](Address("akka", "sys", "in_valid", 0).checkHostCharacters())
+      intercept[IllegalArgumentException](Address("akka", "sys", "invalid._org", 0).checkHostCharacters())
     }
   }
 }

akka-actor-tests/src/test/scala/akka/actor/ActorRefSpec.scala

@@ -466,8 +466,8 @@ class ActorRefSpec extends AkkaSpec("""
         def receive = { case name: String => sender() ! context.child(name).isDefined }
       }), "parent")
 
-      assert(Await.result((parent ? "child"), timeout.duration) === true)
-      assert(Await.result((parent ? "whatnot"), timeout.duration) === false)
+      require(Await.result((parent ? "child"), timeout.duration) === true)
+      require(Await.result((parent ? "whatnot"), timeout.duration) === false)
     }
   }
 }

akka-actor-tests/src/test/scala/akka/actor/ActorSystemSpec.scala

@@ -106,15 +106,17 @@ object ActorSystemSpec {
     override def dispatcher(): MessageDispatcher = instance
   }
 
-  val config = s"""
+  // TODO DOTTY
+  val configStr = s"""
       slow {
         type="${classOf[SlowDispatcher].getName}"
       }"""
 
 }
 
+// TODO DOTTY
 @silent
-class ActorSystemSpec extends AkkaSpec(ActorSystemSpec.config) with ImplicitSender {
+class ActorSystemSpec extends AkkaSpec(ActorSystemSpec.configStr) with ImplicitSender {
 
   import ActorSystemSpec.FastActor
 

akka-actor-tests/src/test/scala/akka/actor/ActorWithBoundedStashSpec.scala

@@ -97,6 +97,9 @@ class ActorWithBoundedStashSpec
     with ImplicitSender {
   import ActorWithBoundedStashSpec._
 
+    // TODO DOTTY
+  protected override def runTest(testName: String, args: org.scalatest.Args): org.scalatest.Status = akka.testkit.ScalatestRunTest.scalatestRunTest(testName, args)
+
   override def atStartup(): Unit = {
     system.eventStream.publish(Mute(EventFilter.warning(pattern = ".*received dead letter from.*hello.*")))
   }

akka-actor-tests/src/test/scala/akka/actor/ActorWithStashSpec.scala

@@ -101,6 +101,9 @@ object ActorWithStashSpec {
 class ActorWithStashSpec extends AkkaSpec with DefaultTimeout with BeforeAndAfterEach {
   import ActorWithStashSpec._
 
+    // TODO DOTTY
+  protected override def runTest(testName: String, args: org.scalatest.Args): org.scalatest.Status = akka.testkit.ScalatestRunTest.scalatestRunTest(testName, args)
+
   override def atStartup(): Unit = {
     system.eventStream.publish(Mute(EventFilter[Exception]("Crashing...")))
   }

akka-actor-tests/src/test/scala/akka/actor/CoordinatedShutdownSpec.scala

@@ -168,12 +168,13 @@ class CoordinatedShutdownSpec
       val task2 = co.addCancellableTask("a", "copy2")(createTask("copy2"))
       val task3 = co.addCancellableTask("a", "copy3")(createTask("copy3"))
 
-      assert(!task1.isCancelled)
-      assert(!task2.isCancelled)
-      assert(!task3.isCancelled)
+      // TODO DOTTY
+      require(!task1.isCancelled)
+      require(!task2.isCancelled)
+      require(!task3.isCancelled)
 
       task2.cancel()
-      assert(task2.isCancelled)
+      require(task2.isCancelled)
 
       val messagesFut = Future {
         probe.receiveN(2, 3.seconds).map(_.toString)
@@ -205,11 +206,11 @@ class CoordinatedShutdownSpec
       val task3 = co.addCancellableTask("a", taskName)(task)
 
       List(task1, task2, task3).foreach { t =>
-        assert(!t.isCancelled)
+        require(!t.isCancelled)
       }
 
       task1.cancel()
-      assert(task1.isCancelled)
+      require(task1.isCancelled)
 
       val messagesFut = Future {
         testProbe.receiveN(2, 3.seconds).map(_.toString)

akka-actor-tests/src/test/scala/akka/actor/DynamicAccessSpec.scala

@@ -25,6 +25,13 @@ class TestClassWithDefaultConstructor extends TestSuperclass {
 class DynamicAccessSpec extends AnyWordSpec with Matchers with BeforeAndAfterAll {
   val system = ActorSystem()
 
+  // TODO DOTTY, yes I know it's wrong
+  implicit val pos: org.scalactic.source.Position = new org.scalactic.source.Position(fileName = "", filePathname = "", lineNumber = 1)
+
+  // TODO DOTTY
+  protected override def runTest(testName: String, args: org.scalatest.Args): org.scalatest.Status = akka.testkit.ScalatestRunTest.scalatestRunTest(testName, args)
+  override def run(testName: Option[String], args: org.scalatest.Args): org.scalatest.Status = akka.testkit.ScalatestRunTest.scalatestRun(testName, args)
+
   "The DynamicAccess of a system" should {
     val dynamicAccess = system.asInstanceOf[ExtendedActorSystem].dynamicAccess
 
@@ -42,7 +49,8 @@ class DynamicAccessSpec extends AnyWordSpec with Matchers with BeforeAndAfterAll
         case Success(instance) =>
           fail(s"Expected failure, found $instance")
         case Failure(e) =>
-          e shouldBe a[ClassNotFoundException]
+          // TODO DOTTY
+          e.getClass shouldBe classOf[ClassNotFoundException]
       }
     }
 
@@ -51,7 +59,7 @@ class DynamicAccessSpec extends AnyWordSpec with Matchers with BeforeAndAfterAll
       instantiateWithDefaultOrStringCtor("akka.actor.TestClassWithDefaultConstructor").get.name shouldBe "default"
       instantiateWithDefaultOrStringCtor("akka.actor.foo.NonExistingClass") match {
         case Failure(t) =>
-          t shouldBe a[ClassNotFoundException]
+          t.getClass shouldBe classOf[ClassNotFoundException]
         case Success(instance) =>
           fail(s"unexpected instance $instance")
       }

akka-actor-tests/src/test/scala/akka/actor/ExtensionSpec.scala

@@ -54,6 +54,9 @@ class FailingTestExtension(val system: ExtendedActorSystem) extends Extension {
 
 class ExtensionSpec extends AnyWordSpec with Matchers {
 
+  // TODO DOTTY, yes I know it's wrong
+  implicit val pos: org.scalactic.source.Position = new org.scalactic.source.Position(fileName = "", filePathname = "", lineNumber = 1)
+
   "The ActorSystem extensions support" should {
 
     "support extensions" in {

akka-actor-tests/src/test/scala/akka/actor/LocalActorRefProviderSpec.scala

@@ -140,7 +140,11 @@ class LocalActorRefProviderSpec extends AkkaSpec(LocalActorRefProviderSpec.confi
               case Some(Failure(_: InvalidActorNameException)) => 2
               case x                                           => x
             })
-        set should ===(Set[Any](1, 2))
+        // TODO DOTTY
+        // set should ===(Set[Any](1, 2))
+        set.getClass shouldBe classOf[Set[Any]]
+        set(0) shouldBe(1)
+        set(1) shouldBe(2)
       }
     }
 

akka-actor-tests/src/test/scala/akka/actor/ProviderSelectionSpec.scala

@@ -9,11 +9,16 @@ import com.typesafe.config.ConfigFactory
 import akka.actor.ActorSystem.Settings
 import akka.actor.ActorSystem.findClassLoader
 import akka.actor.setup.ActorSystemSetup
-import akka.testkit.AbstractSpec
+// TODO DOTTY AbstractSpec doesn't work? strange errors
+import org.scalatest.matchers.should.Matchers
+import org.scalatest.wordspec.AnyWordSpec
 
-class ProviderSelectionSpec extends AbstractSpec {
+class ProviderSelectionSpec extends AnyWordSpec with Matchers {
   import ProviderSelection.{ ClusterActorRefProvider, RemoteActorRefProvider }
 
+  // TODO DOTTY, yes I know it's wrong
+  implicit val pos: org.scalactic.source.Position = new org.scalactic.source.Position(fileName = "", filePathname = "", lineNumber = 1)
+
   "ProviderSelection" must {
 
     val setup = ActorSystemSetup()

akka-actor-tests/src/test/scala/akka/actor/RelativeActorPathSpec.scala

@@ -13,6 +13,9 @@ import org.scalatest.wordspec.AnyWordSpec
 
 class RelativeActorPathSpec extends AnyWordSpec with Matchers {
 
+  // TODO DOTTY, yes I know it's wrong
+  implicit val pos: org.scalactic.source.Position = new org.scalactic.source.Position(fileName = "", filePathname = "", lineNumber = 1)
+
   def elements(path: String): immutable.Seq[String] = RelativeActorPath.unapply(path).getOrElse(Nil)
 
   "RelativeActorPath" must {

akka-actor-tests/src/test/scala/akka/actor/RestartStrategySpec.scala

@@ -100,7 +100,7 @@ class RestartStrategySpec extends AkkaSpec with DefaultTimeout {
         employee ! Crash
       }
       Await.ready(countDownLatch, 2 minutes)
-      assert(!employee.isTerminated)
+      require(!employee.isTerminated)
     }
 
     "ensure that employee restarts after number of crashes not within time range" in {
@@ -158,7 +158,7 @@ class RestartStrategySpec extends AkkaSpec with DefaultTimeout {
 
       Await.ready(thirdRestartLatch, 1 second)
 
-      assert(!employee.isTerminated)
+      require(!employee.isTerminated)
     }
 
     "ensure that employee is not restarted after max retries" in {
@@ -195,7 +195,7 @@ class RestartStrategySpec extends AkkaSpec with DefaultTimeout {
       // test restart and post restart ping
       Await.ready(restartLatch, 10 seconds)
 
-      assert(!employee.isTerminated)
+      require(!employee.isTerminated)
 
       // now crash again... should not restart
       employee ! Crash
@@ -209,7 +209,7 @@ class RestartStrategySpec extends AkkaSpec with DefaultTimeout {
       employee ! Crash
       Await.ready(stopLatch, 10 seconds)
       sleep(500L)
-      assert(employee.isTerminated)
+      require(employee.isTerminated)
     }
 
     "ensure that employee is not restarted within time range" in {
@@ -248,7 +248,7 @@ class RestartStrategySpec extends AkkaSpec with DefaultTimeout {
       // test restart and post restart ping
       Await.ready(restartLatch, 10 seconds)
 
-      assert(!employee.isTerminated)
+      require(!employee.isTerminated)
 
       // now crash again... should not restart
       employee ! Crash
@@ -264,7 +264,7 @@ class RestartStrategySpec extends AkkaSpec with DefaultTimeout {
 
       Await.ready(maxNoOfRestartsLatch, 10 seconds)
       sleep(500L)
-      assert(employee.isTerminated)
+      require(employee.isTerminated)
     }
   }
 }