Use assertThrows in classes ActorCreationTest and OutputStreamSinkTest

[Captain1653]

Thare are many lines look like that:
try ... catch in tests. It can be replaced on assertThrows

Kind regards

[akka-ci]

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK ΤO ΤESΤ' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

[johanandren]

OK TO TEST

[akka-ci]

Test FAILed.

[akka-ci]

Test FAILed.

[Captain1653]

Hm... It looks like some infrastructure error
The command "curl -Ls https://git.io/jabba | bash && . ~/.jabba/jabba.sh" failed and exited with 1 during . Am I wrong?

And some strage test testWrongAnonymousInPlaceCreator . I refactored it, saved semantics, but it failed... Really strange for me.

[johanandren]

Yeah, was something temporary yesterday, I'll trigger a rebuild.

[johanandren]

PLS BUILD

[akka-ci]

Test FAILed.

[akka-ci]

Test FAILed.

[Captain1653]

I don't understand indeed. The test testWrongAnonymousInPlaceCreator failed. Why? It depends on Java 8 Lambda? Should I revert my change?

[johanandren]

Unless you can figure it out and make the test pass, yes revert please.

[akka-ci]

Test PASSed.

[Captain1653]

@johanandren review it, please

[octonato]

I found why that other test was not failing. That's because the original one was also not failing:

    try {
      Props.create(
          Actor.class,
          new Creator<Actor>() {
            @Override
            public Actor create() throws Exception {
              return null;
            }
          });
      assert false;
    } catch (IllegalArgumentException e) {
      assertEquals(
          "cannot use non-static local Creator to create actors; make it static (e.g. local to a static method) or top-level",
          e.getMessage());
    }

That won't fail, because it is using java assertions. Assertions aren't enabled by default.

So, the Props.create pass (while the test tries to prove that it should fail).

Then, the assert isn't executed and the assertEquals inside the catch block never gets executed.

Replace the assert by org.junit.Assert.fail("above code should have failed"); and that test fails.

[octonato]

@Captain1653, do you want to take a stab on it and try to fix that test? By fixing, I mean, ensure that it will indeed fail the call and throw an IllegalArgumentException?

[Captain1653]

@octonato Thank you for your explanation. I didn't guess))). Yes, I can try to do it. It looks interesting. Should it be some different issue and different PR? For me - yes, because it's the different problem (not refactor). What do you think?

P.S. I tried to search places with "assert " in source code. It was used many times.

Is it worth to fix it in the different issue and different PR? (replace on assertEquals or similar)

Kind regards

[octonato]

Yes, you are right. I think we should fix it on a different PR. Let's not mix things.