Resolve missing internal state update in EventSourcedRememberEntities… #30217
Conversation
|
Hi @jneumaier, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK ΤO ΤESΤ' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged. For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask! |
|
OK TO TEST |
akka-ci
added
validating
|
Test FAILed. |
...-sharding/src/test/scala/akka/cluster/sharding/internal/RememberEntitiesShardStoreSpec.scala
Show resolved
Hide resolved
…sShardStore, simplify test (akka#30215)
akka-ci
added
validating
|
Test FAILed. |
…sShardStore, fix scalafmt (akka#30215)
akka-ci
added
validating
|
Test PASSed. |
|
@chbatey You also contributed to EventSourcedRememberEntitiesShardStore, maybe you can do a review? |
| @@ -101,7 +101,7 @@ private[akka] final class EventSourcedRememberEntitiesShardStore( | |||
| left -= 1 | |||
| if (left == 0) { | |||
| sender() ! RememberEntitiesShardStore.UpdateDone(started, stopped) | |||
| state.copy(state.entities.union(started).diff(stopped)) | |||
| state = state.copy(state.entities.union(started).diff(stopped)) | |||
See #30215