Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StandardCharsets.UTF-8 in SerializationDocTest #30233

Merged
merged 1 commit into from
May 12, 2021
Merged

Use StandardCharsets.UTF-8 in SerializationDocTest #30233

merged 1 commit into from
May 12, 2021

Conversation

Captain1653
Copy link
Contributor

StandartCharsets.UTF-8 since java 1.7 ​can be used to avoid UnsupportedEncodingException

Kind regards

@akka-ci
Copy link

akka-ci commented May 10, 2021

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK ΤO ΤESΤ' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

@raboof
Copy link
Member

raboof commented May 10, 2021

OK TO TEST

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels May 10, 2021
@akka-ci
Copy link

akka-ci commented May 10, 2021

Test FAILed.

@Captain1653
Copy link
Contributor Author

Hmm... I have strange build result. Tests are green. And label is tested. Should be 'need-attention'?

[0m[�[0m�[0minfo�[0m] �[0m�[0mPassed: Total 632, Failed 0, Errors 0, Passed 632, Ignored 6, Pending 1�[0m
�[0m[�[0m�[32msuccess�[0m] �[0m�[0mTotal time: 142 s (02:22), completed May 10, 2021 6:28:54 PM�[0m
�[0J[Current build status] check if current [SUCCESS] is worse or equals then [SUCCESS] and better or equals then [SUCCESS]
Run condition [Current build status] enabling perform for step [Execute shell]
[pr-validator-per-commit-jenkins] $ /bin/bash -xe /tmp/jenkins9191475966342439860.sh

  • '[' -x scripts/build/extra-build-steps.sh ']'
    [pr-validator-per-commit-jenkins] $ /bin/bash -xe /tmp/jenkins1174644031675801595.sh
  • date
    Mon May 10 18:28:55 CEST 2021
    Archiving artifacts
    An attempt to send an e-mail to empty list of recipients, ignored.
    [PostBuildScript] - [INFO] Executing post build scripts.
    [pr-validator-per-commit-jenkins] $ /bin/bash -xe /tmp/jenkins1356468414472522509.sh
  • rm -rf /localhome/jenkinsakka/pr-validator-per-commit-jenkins/21650
  • ssh a5.local rm -rf /localhome/jenkinsakka/pr-validator-per-commit-jenkins/21650
    ssh: Could not resolve hostname a5.local: Name or service not known
    [Current build status] check if current [SUCCESS] is worse or equals then [SUCCESS] and better or equals then [SUCCESS]
    Run condition [Current build status] enabling perform for step [Execute shell]
    [pr-validator-per-commit-jenkins] $ /bin/bash -xe /tmp/jenkins1317045395655570977.sh
  • '[' -f scripts/build/github-tagging.sh ']'
  • . scripts/build/github-tagging.sh
  • set +x
    Tagging 30233 with 'tested'
    [Current build status] check if current [SUCCESS] is worse or equals then [ABORTED] and better or equals then [UNSTABLE]
    Run condition [Current build status] preventing perform for step [Execute shell]
    Build step 'Execute scripts' changed build result to FAILURE
    Build step 'Execute scripts' marked build as failure
    Recording test results
    [Checks API] No suitable checks publisher found.
    Adding one-line test results to commit status...
    Setting status of 0ee9532 to FAILURE with url https://jenkins.akka.io:8498/job/pr-validator-per-commit-jenkins/21650/ and message: 'Test FAILed.
    639 tests run, 7 skipped, 0 failed.'
    Using context: Jenkins PR Validation
    Test FAILed.

Finished: FAILURE

@raboof
Copy link
Member

raboof commented May 10, 2021

Sorry, this is caused by an outage in our jenkins infra (the relevant line is ssh: Could not resolve hostname a5.local: Name or service not known). It has nothing to do with this PR and we expect/hope it to be fixed tomorrow.

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed tested PR that was successfully built and tested by Jenkins validating PR is currently being validated by Jenkins labels May 10, 2021
@akka-ci
Copy link

akka-ci commented May 10, 2021

Test PASSed.

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit 240378f into akka:master May 12, 2021
@patriknw patriknw added this to the 2.6.15 milestone May 12, 2021
@Captain1653 Captain1653 deleted the use-standart-charsets branch May 12, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants