-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use StandardCharsets.UTF-8 in SerializationDocTest #30233
Conversation
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK ΤO ΤESΤ' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged. For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask! |
OK TO TEST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Test FAILed. |
Hmm... I have strange build result. Tests are green. And label is [0m[�[0m�[0minfo�[0m] �[0m�[0mPassed: Total 632, Failed 0, Errors 0, Passed 632, Ignored 6, Pending 1�[0m
Finished: FAILURE |
Sorry, this is caused by an outage in our jenkins infra (the relevant line is |
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
StandartCharsets.UTF-8 since java 1.7 can be used to avoid UnsupportedEncodingException
Kind regards