Fix test ActorCreationTest.testWrongAnonymousInPlaceCreator

[Captain1653]

References #30220

Looks like the method checkCreatorClosingOver was used in deprecated Props.create(Creator), but was forgotten in new Props.create(ActorClass,Creator).

Kind regards

[akka-ci]

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK ΤO ΤESΤ' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

[patriknw]

OK TO TEST

[patriknw]

LGTM

[akka-ci]

Test FAILed.

[octonato]

This failed with...

sbt.ForkMain$ForkError: java.lang.NullPointerException: null
	at akka.actor.AbstractProps.create(AbstractProps.scala:78)
	at akka.actor.AbstractProps.create$(AbstractProps.scala:77)
	at akka.actor.Props$.create(Props.scala:22)
	at akka.actor.PropsCreationSpec.$anonfun$new$9(PropsCreationSpec.scala:68)
	at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
	at org.scalatest.OutcomeOf.outcomeOf$(OutcomeOf.scala:83)
	at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
	at org.scalatest.Transformer.apply(Transformer.scala:22)
	at org.scalatest.Transformer.apply(Transformer.scala:20)

and it seems that the passed creator is null. It's blowing up on creator.getClass.

Strange!

[octonato]

I found it. The failure comes from another spec.

akka/akka-actor-tests/src/test/scala/akka/actor/PropsCreationSpec.scala

Line 68 in da70e0c

val p = Props.create(classOf[OneParamActor], null)

This is passing a null creator.

[Captain1653]

Use Props(classOf[Actor], OneParamActorCreator) , because Props(classOf[OneParamActor], OneParamActorCreator) throws

type mismatch;
 found   : Class[akka.actor.PropsCreationSpec.OneParamActor](classOf[akka.actor.PropsCreationSpec$$OneParamActor])
 required: Class[akka.actor.Actor]
Note: akka.actor.PropsCreationSpec.OneParamActor <: akka.actor.Actor, but Java-defined class Class is invariant in type T.
You may wish to investigate a wildcard type such as `_ <: akka.actor.Actor`. (SLS 3.2.10)
      val p = Props.create(classOf[OneParamActor], OneParamActorCreator)

[akka-ci]

Test FAILed.

[Captain1653]

Infrastructure error
ssh: Could not resolve hostname a5.local: Name or service not known

[akka-ci]

Test PASSed.

[octonato]

👍