Optimized general byte string array access #30263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test FAILed. |
patriknw
reviewed
May 26, 2021
| @@ -271,6 +269,11 @@ object ByteString { | |||
| toCopy | |||
| } | |||
|
|
|||
| override def toArrayUnsafe(): Array[Byte] = bytes | |||
|
|
|||
| override def foldLeftArrayUnsafe[T](zero: T)(f: (T, Array[Byte], Int, Int) => T): T = | |||
There was a problem hiding this comment.
Ok, this should be possible to use with proto.UnsafeByteOperations.unsafeWrap(bytes, offset, length), and proto.ByteString.concat.
An alternative could be to use the existing akka.ByteString.asByteBuffers.
Is there a public api to see if it's a ByteString1? Because then we could use that to choose between toArrayUnsafe or slightly more costly toArrayUnsafe.
There was a problem hiding this comment.
The concrete ByteString classes are actually public, so you could use isInstanceOf to detect ByteString1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on top of #30262
Refs #30257
Not sure this is needed, but just to jot the idea down.