Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterShardingLeaseSpec: extractShardId should include StartEntity #30632

Merged
merged 1 commit into from Sep 6, 2021

Conversation

octonato
Copy link
Member

@octonato octonato commented Sep 3, 2021

References #30622

The shard was never coming back to life because of the following exception.

java.lang.IllegalArgumentException
 at akka.cluster.sharding.ClusterShardingLeaseSpec$.$anonfun$extractShardId$1(ClusterShardingLeaseSpec.scala:55)
 at akka.cluster.sharding.ShardRegion.deliverMessage(ShardRegion.scala:1245)
 at akka.cluster.sharding.ShardRegion.deliverStartEntity(ShardRegion.scala:1213)
 at akka.cluster.sharding.ShardRegion$$anonfun$receive$2.applyOrElse(ShardRegion.scala:732) 
 at akka.actor.Actor.aroundReceive(Actor.scala:537) 
 at akka.actor.Actor.aroundReceive$(Actor.scala:535)
 at akka.cluster.sharding.ShardRegion.akka$actor$Timers$$super$aroundReceive(ShardRegion.scala:588) 
 at akka.actor.Timers.aroundReceive(Timers.scala:56)
 at akka.actor.Timers.aroundReceive$(Timers.scala:41)

StartEntity was getting in before the Int sent by the test. Surprising that we never hit that before (or didn't notice).

@octonato octonato changed the title extractShardId should include StartEntity Harden ClusterShardingLeaseSpec: extractShardId should include StartEntity Sep 3, 2021
@octonato octonato changed the title Harden ClusterShardingLeaseSpec: extractShardId should include StartEntity ClusterShardingLeaseSpec: extractShardId should include StartEntity Sep 3, 2021
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit 42c2329 into master Sep 6, 2021
@patriknw patriknw deleted the rgc/harden-cluster-sharding-lease-spec branch September 6, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants