Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MessageAdapterSpec instability #30662

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

raboof
Copy link
Member

@raboof raboof commented Sep 8, 2021

Consume dead letters in one test so they don't
pollute the next test

Fixes #30552

Consume dead letters in one test so they don't
pollute the next test

Fixes akka#30552
@raboof
Copy link
Member Author

raboof commented Sep 8, 2021

Hmm, the failure is actually in the test that was touched in this PR, weird that I didn't see this locally:

must not catch exception thrown after adapter, when processing the message *** FAILED *** (24 milliseconds)
[info]   Pong(hello) was not equal to Pong(hello) (MessageAdapterSpec.scala:273)
[info]   org.scalatest.exceptions.TestFailedException:
[info]   at org.scalatest.matchers.MatchersHelper$.indicateFailure(MatchersHelper.scala:402)
[info]   at org.scalatest.matchers.should.Matchers.shouldBe(Matchers.scala:6985)
[info]   at org.scalatest.matchers.should.Matchers.shouldBe$(Matchers.scala:1808)
[info]   at akka.actor.testkit.typed.scaladsl.ScalaTestWithActorTestKit.shouldBe(ScalaTestWithActorTestKit.scala:31)
[info]   at akka.actor.typed.scaladsl.MessageAdapterSpec.f$proxy5$2(MessageAdapterSpec.scala:273)
[info]   at 

@raboof raboof self-assigned this Sep 8, 2021
@raboof
Copy link
Member Author

raboof commented Sep 8, 2021

(mima failures are fixed with #30665 )

@raboof raboof merged commit 4f750f1 into akka:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed: MessageAdapterSpec - redirect to DeadLetter after termination
2 participants