fix(stream): in TlsActor flush data to user only after handshake has finished #31433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrudolph
force-pushed
the
fix-tls-session-on-tls-1-3
branch
from
2bfed8b
to
9bb284f
Compare
…finished Refs akka#31419 In TLS 1.3, the server also sends out a NewSessionTicket message at the end of the handshake. This is flagged by `NEED_WRAP`. In some cases, we have already decoded user data. However, we only update the current session in `handshakeFinished` which is only called after we have sent out that extra handshake package. This fix delays sending out any data to the user until the handshake is finished as reported by the SslEngine.
jrudolph
force-pushed
the
fix-tls-session-on-tls-1-3
branch
from
9bb284f
to
17c9242
Compare
jrudolph
changed the title
|
@jrudolph we built a local artifact from your branch and we are not able to reproduce the issue. Any chance this fix will be merged and released any time soon? Thanks! |
|
Thanks for verifying that it fixes the issue @adibaranga , I think that was what was missing to move on with this PR |
johanandren
added
the
2 - pick next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #31419
Tentative fix. I haven't been able to reproduce it in the tests yet...