Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala Steward's PR naming #31754

Merged
merged 2 commits into from Nov 22, 2022
Merged

Update Scala Steward's PR naming #31754

merged 2 commits into from Nov 22, 2022

Conversation

ennru
Copy link
Member

@ennru ennru commented Nov 21, 2022

No description provided.

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@@ -1,8 +1,9 @@
commits.message = "bump: ${artifactName} ${nextVersion} (was ${currentVersion})"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I have adjusted the contributing guidelines #31755

pullRequests.frequency = "@monthly"

updates.pin = [
{ groupId = "org.scalatest", artifactId = "scalatest", version = "3.1." }
{ groupId = "com.fasterxml.jackson.core", artifactId = "jackson-core", version = "2.11." }
{ groupId = "com.fasterxml.jackson.core", artifactId = "jackson-core", version = "2.13." }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to remove the ignore of databind because security micro patches are often added there, and also pin databind to 2.13

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit 8e298af into akka:main Nov 22, 2022
@patriknw patriknw added this to the 2.8.0-M1 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants