Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: multi-node testkit throttle not implemented in Artery #31774

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

patriknw
Copy link
Member

This has always been the case but showed up after removing classic remoting #31765
I'm surprised but that means that the TestConductorSpec was previously only running with classic.

multi-node test failure:

2022-11-30T02:52:42.0237412Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m[�[34mJVM-2�[0m] scala.MatchError: SetThrottle(akka://TestConductorSpec@test-node1:5000,Send,TokenBucket(1000,1249.9999720603228,0,0)) (of class akka.remote.testkit.SetThrottle)�[0m
2022-11-30T02:52:42.0239423Z �[0m[�[0m�[0minfo�[0m] �[0m�[0m[�[34mJVM-2�[0m] 	at akka.remote.artery.ArteryTransport.managementCommand(ArteryTransport.scala:673)�[0m

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit 49dd7b6 into main Nov 30, 2022
@patriknw patriknw deleted the wip-testtransport-patriknw branch November 30, 2022 14:59
@patriknw patriknw added this to the 2.8.0-M2 milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants