ci: Remove special-casing Scala 3 #31775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Nov 30, 2022
patriknw
reviewed
Nov 30, 2022
.github/workflows/nightly-builds.yml
Outdated
| @@ -86,7 +86,7 @@ jobs: | |||
| # No need to specify the full Scala version. Only the Scala | |||
| # binary version is required and Akka build will set the right | |||
| # full version from it. | |||
| scalaVersion: ["2.12", "2.13"] | |||
| scalaVersion: ["2.12", "2.13", "3.1"] | |||
| jdkVersion: ["1.8.0", "1.11", "1.17.0"] | |||
There was a problem hiding this comment.
Does this mean that it will run all 9 combinations? Previously 6.
I think it's overkill to test all combinations.
There was a problem hiding this comment.
Updated, to use an explicit matrix. Note that PR validations don't run all tests.
johanandren
reviewed
Nov 30, 2022
|
The failing workflow shows why we needed to extend it, fixed in main with #31773. |
johanandren
approved these changes
Nov 30, 2022
ennru
force-pushed
the
ennru-scala3-normal
branch
from
e0717ff
to
19b59e2
Compare
johanandren
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test/compileacross all Scala versions in MiMa validation (runs on PRs and pushes to main branches)