fix: Only one retention cycle in progress at a time, #31785 #31786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
approved these changes
Dec 9, 2022
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/BehaviorSetup.scala
Outdated
Show resolved
Hide resolved
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/BehaviorSetup.scala
Outdated
Show resolved
Hide resolved
akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/Running.scala
Outdated
Show resolved
Hide resolved
* Keep track of retention steps, including detailed debug logging.
* If retention is in progress when a new retention is triggered it will
skip that retention cycle.
* Had to include that as mutable state in BehaviorSetup rather than in the
RunningState because the background tasks of deleting events and snapshots
can't easily update the RunningState.
* Also changed so that snapshot deletion always use 0 as lower sequence number.
* This is important because otherwise some snapshots may be left behind when
retention is skipped. That could probably already happen in failure scenarios
previously.
The retention process for SnapshotCountRetentionCriteria looks like this:
1. Save snapshot after persisting events when shouldSnapshotAfterPersist returned SnapshotWithRetention.
2. Delete events (when deleteEventsOnSnapshot=true), runs in background.
3. Delete snapshots (when isOnlyOneSnapshot=false), runs in background.
patriknw
force-pushed
the
wip-31785-retention-inprogress-patriknw
branch
from
cfc7de3
to
91dcee7
Compare
This was referenced Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #31784 but otherwise ready for review.
The retention process for SnapshotCountRetentionCriteria looks like this:
References #31785