fix: EventSourcedBehaviorRetentionSpec fail #31809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonato
approved these changes
Jan 6, 2023
johanandren
deleted the
wip-31796-EventSourcedBehaviorRetentionSpec-fail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #31796
The changes in #31785 means that retention deletes can be skipped if one is already in progress. The test expected that the retention/deletes they are always run and fired off events that should trigger 3 deletes at once, if the deletes complete or not before the next retention is triggered depends on how fast the machine is (hint ci is slow)
This fix runs the events in batches verifying each delete before triggering the next making it deterministic again.
Verified by sneaking strategic Thread.sleeps into the testkit snapshot store operations.