-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: recommend new gRPC transport for replicated event sourcing #31828
Conversation
ccfa21e
to
db6ff0d
Compare
Complete samples of the gRPC transport set up can be found in the Akka Projection github repository: | ||
|
||
* [Replicated shopping cart service in Scala](https://github.com/akka/akka-projection/tree/main/samples/replicated/shopping-cart-service-scala) | ||
* [Replicated shopping cart service in Java](https://github.com/akka/akka-projection/tree/main/samples/replicated/shopping-cart-service-java) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also have replicated-eventsourcing-examples.md
, should these be linked from there as well?
|
||
### Consuming events via direct access to replica databases | ||
|
||
It is also possible to consume events with a direct connection to the database of each replica. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, but we also have a few more sections below that are not relevant for gRPC transport. Add a note or something to those?
- Direct Replication of Events
- Hot Standby
- Sharded Replicated Event Sourced entities (the multi-dc part)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it would be best to place everything that has with "direct access to replica databases" in a new separate page, and have this page for general content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, let's break it out to a separate page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I have pulled everything direct-transport specific out now
@@@ | ||
|
||
## Additional samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't get the external links in the index/toc but this header ends up in the index leading to this page. Perhaps not great, but it works.
Separating it out is ok at best. Quite messy having to go over to the projection docs, best would be a complete overview in the Akka docs, but we don't want that dependency, and we don't want textual code snippets, so not sure what to do. Perhaps we just accept this for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.