Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: recommend new gRPC transport for replicated event sourcing #31828

Merged
merged 5 commits into from
Feb 16, 2023

Conversation

johanandren
Copy link
Member

No description provided.

@johanandren johanandren force-pushed the wip-grpc-recommendation-for-res branch from ccfa21e to db6ff0d Compare February 2, 2023 09:56
@akka akka deleted a comment from lightbend-cla-validator Feb 2, 2023
@patriknw patriknw added this to the 2.8.0-M5 milestone Feb 2, 2023
Complete samples of the gRPC transport set up can be found in the Akka Projection github repository:

* [Replicated shopping cart service in Scala](https://github.com/akka/akka-projection/tree/main/samples/replicated/shopping-cart-service-scala)
* [Replicated shopping cart service in Java](https://github.com/akka/akka-projection/tree/main/samples/replicated/shopping-cart-service-java)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also have replicated-eventsourcing-examples.md, should these be linked from there as well?


### Consuming events via direct access to replica databases

It is also possible to consume events with a direct connection to the database of each replica.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but we also have a few more sections below that are not relevant for gRPC transport. Add a note or something to those?

  • Direct Replication of Events
  • Hot Standby
  • Sharded Replicated Event Sourced entities (the multi-dc part)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be best to place everything that has with "direct access to replica databases" in a new separate page, and have this page for general content.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's break it out to a separate page

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have pulled everything direct-transport specific out now

@@@

## Additional samples
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't get the external links in the index/toc but this header ends up in the index leading to this page. Perhaps not great, but it works.

@johanandren
Copy link
Member Author

Separating it out is ok at best. Quite messy having to go over to the projection docs, best would be a complete overview in the Akka docs, but we don't want that dependency, and we don't want textual code snippets, so not sure what to do. Perhaps we just accept this for now?

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit eca5ffb into main Feb 16, 2023
@patriknw patriknw deleted the wip-grpc-recommendation-for-res branch February 16, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants