Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=str Implement Source.never as a dedicated GraphStage. #31902

Merged
merged 1 commit into from
Apr 12, 2023
Merged

=str Implement Source.never as a dedicated GraphStage. #31902

merged 1 commit into from
Apr 12, 2023

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Apr 1, 2023

Using a more straightforward implementation will reduce the AsyncCallback in FutureSource.

patriknw
patriknw approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren johanandren merged commit 7a6276d into akka:main Apr 12, 2023
@johanandren johanandren added this to the 2.8.1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

@johanandren johanandren johanandren approved these changes

Assignees
No one assigned
Labels
t:stream
Projects
None yet
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@He-Pin @patriknw @johanandren